fix(FnF): don't fetch outstanding statements on every save #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrms/hr/doctype/full_and_final_statement/full_and_final_statement.py
Outdated
Show resolved
Hide resolved
ruchamahabal
changed the title
hrms/hr/doctype/full_and_final_statement/full_and_final_statement.py
Outdated
Show resolved
Hide resolved
ruchamahabal
approved these changes
Aug 23, 2023
|
Thank you @ruchamahabal |
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
The user cannot leave the receivables tables empty in the doctype. With each save, loans and employee advances are added to the table. (cherry picked from commit 266f270)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
## [14.10.2](v14.10.1...v14.10.2) (2023-08-23) ### Bug Fixes * Allow float for `Maximum Leave Allocation Allowed` (backport [#789](#789)) ([#800](#800)) ([b931037](b931037)) * allow optional tax component addition & removal (backport [#814](#814)) ([#815](#815)) ([186e882](186e882)) * **FnF:** don't fetch outstanding statements on every save (backport [#797](#797)) ([#816](#816)) ([3664517](3664517)) * **Shift Type:** rename misleading Enable Entry/Exit Grace Period checkbox label (backport [#784](#784)) ([#799](#799)) ([f3a11e8](f3a11e8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user cannot leave the receivables tables empty in the doctype. With each save, loans and employee advances are added to the table.