fix(Salary Structure Assignment): validate cost center company on server-side #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [14.35.2](v14.35.1...v14.35.2) (2024-11-26) ### Bug Fixes * filters on vehicle expenses report (backport [#2440](#2440)) ([#2446](#2446)) ([6d35f11](6d35f11)) * ignore linked ledger entry record on employee advance cancellation (backport [#2432](#2432)) ([#2434](#2434)) ([8058d74](8058d74)) * **Salary Structure Assignment:** validate cost center company on server-side (backport [#2445](#2445)) ([#2449](#2449)) ([51831cb](51831cb))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [15.35.3](v15.35.2...v15.35.3) (2024-11-26) ### Bug Fixes * Editable Letter Head field in Salary Structure Doctype (backport [#2436](#2436)) ([#2443](#2443)) ([f948a36](f948a36)) * filters on vehicle expenses report (backport [#2440](#2440)) ([#2447](#2447)) ([4e4425c](4e4425c)) * ignore linked ledger entry record on employee advance cancellation (backport [#2432](#2432)) ([#2433](#2433)) ([e1d9514](e1d9514)) * redundant fetching of Interviewers in Interview ([#2441](#2441)) ([62cd631](62cd631)) * **Salary Structure Assignment:** validate cost center company on server-side (backport [#2445](#2445)) ([#2450](#2450)) ([7f5e969](7f5e969))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a filter for cost center selection based on company in Salary Structure Assignment already. But that won't work when assignments are created via data import.
This error doesn't get caught until accrual entry for payroll is attempted and it fails silently:
Add a server-side validation in Salary Structure Assignment itself: