-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Earned Leave UX Enhancement #1156
Open
krantheman
wants to merge
11
commits into
frappe:develop
Choose a base branch
from
krantheman:earned-leave-enhancement
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+306
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on Allocating Leaves Manually
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1156 +/- ##
===========================================
- Coverage 72.75% 72.28% -0.47%
===========================================
Files 199 200 +1
Lines 10769 10922 +153
===========================================
+ Hits 7835 7895 +60
- Misses 2934 3027 +93
|
krantheman
force-pushed
the
earned-leave-enhancement
branch
from
December 12, 2023 07:59
8a83922
to
cf000ad
Compare
krantheman
force-pushed
the
earned-leave-enhancement
branch
from
December 12, 2023 08:02
cf000ad
to
378f4be
Compare
krantheman
force-pushed
the
earned-leave-enhancement
branch
from
December 13, 2023 07:00
9f4eb11
to
1b75334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes: #1104
Changes
Monthly leave allocation schedule
Shows the date and the number of leaves to be allocated each month in the Leave Allocation form dashboard. This table is only rendered for Earned Leaves with 'Monthly' frequency.
Notification of auto-allocation failure
In case of failure of auto-allocation of Earned Leaves, an email is sent to the users with the 'HR Manager' role, notifying them of said failure.
Manual allocation of leaves
"Allocate Leaves Manually" button to circumvent missed Leave Allocations due to failed background jobs. Number of leaves is defaulted to the monthly number of leaves to be allocated.
Documentation
https://frappehr.com/docs/v14/en/configuring-earned-leave