lsp: Fix client error handling (#2205)

fox0430 · Nov 20, 2024 · fc38051 · fc38051
1 parent 4db7d62
commit fc38051
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/changelog.d/20241120_233351_github-actions[bot]_lsp-client-error-handling.rst b/changelog.d/20241120_233351_github-actions[bot]_lsp-client-error-handling.rst
@@ -0,0 +1,7 @@
+.. _#2205:  https://github.com/fox0430/moe/pull/2205
+
+Fixed
+.....
+
+- `#2205`_  lsp: Fix client error handling
+
diff --git a/src/moepkg/lsp/jsonrpc.nim b/src/moepkg/lsp/jsonrpc.nim
@@ -154,6 +154,13 @@ proc read*(s: OutputStream): Future[JsonRpcResponseResult] {.async.} =
   else:
     return JsonRpcResponseResult.err fmt"Invalid jsonrpc: {$res}"
 
+proc write(s: InputStream, req: string) {.async.} =
+  try:
+    await s.stream.write(req)
+  except:
+    # TODO: Add messages to error log.
+    discard
+
 proc send(
   s: InputStream,
   frame: string): Future[Result[(), string]] {.async.} =
@@ -163,10 +170,7 @@ proc send(
 
     debugLog(MessageType.write, req)
 
-    try:
-      asyncSpawn s.stream.write(req)
-    except CatchableError as e:
-      return Result[(), string].err e.msg
+    asyncSpawn s.write(req)
 
     return Result[(), string].ok ()