feat: Play videos in the app #2109 #2488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 79df4c8. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 323055c. Here's the output:
|
shubhamkumar1739
force-pushed
the
youtube
branch
4 times, most recently
from
79df4c8
to
d451427
Compare
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout
Add a callback (ChatCallback) which plays youtube fragment from the ChatActivity
REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739
force-pushed
the
youtube
branch
from
b7bd91b
to
1e9fb07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2109 Play videos in the app
Changes: Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout
Change the onClick function in YoutubeVideoViewHolder.kt to call the fragment instead of YoutubeVid.kt
Important: Give YouTube API key for proper functioning
Screenshots for the change: