-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement organizer onboarding process | Check if Organizer has unpaid invoice #444
Implement organizer onboarding process | Check if Organizer has unpaid invoice #444
Conversation
Reviewer's Guide by SourceryThis PR implements a validation check that prevents event organizers from publishing events if they have any unpaid or expired invoices. The implementation adds a new method to check for unpaid invoices in the Organizer model and uses it as part of the event's live issues validation. Sequence diagram for event publication checksequenceDiagram
actor Organizer
participant Event
participant BillingInvoice
Organizer->>Event: Request to publish event
Event->>Organizer: Check has_unpaid_invoice()
Organizer->>BillingInvoice: Query unpaid invoices
BillingInvoice-->>Organizer: Return invoice count
alt Unpaid invoices exist
Event-->>Organizer: Reject publication
else No unpaid invoices
Event-->>Organizer: Allow publication
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using constants or enums instead of magic strings 'n' and 'e' for invoice status checks to improve code maintainability
- Please add tests to verify the unpaid invoice checking behavior, especially around event publishing restrictions
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR partly resolves issue #379 Implement organizer onboarding process
This PR implement:
Summary by Sourcery
New Features: