Sweep: Pagination Missing on "Shop Summary" Merchant Table (✓ Sandbox Passed) #100

sweep-ai · 2024-02-03T19:06:56Z

PR Feedback: 👎

Description

This pull request adds pagination functionality to the "Shop Summary" merchant table. It includes changes to the ShopsController, PaginationHelper, index.html.erb, and routes.rb files.

Summary

Added index action to ShopsController to fetch paginated shops
Created PaginationHelper module with methods for custom pagination rendering
Modified index.html.erb to include pagination for @shops
Updated routes.rb to add a route for shops#index with pagination parameter

Fixes #96.

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

sweep-ai · 2024-02-03T19:06:57Z

Rollback Files For Sweep

Rollback changes to app/helpers/pagination_helper.rb
Rollback changes to app/controllers/shops_controller.rb
Rollback changes to config/routes.rb
Rollback changes to app/views/shops/index.html.erb

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:08:14Z

app/helpers/pagination_helper.rb

+
+  def link_to_previous_page(collection, options)
+    unless collection.first_page?
+      link_to 'Previous', url_for(page: collection.prev_page), class: options[:previous_class] || "prev-page"


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

link_to 'Previous', url_for(page: collection.prev_page), class: options[:previous_class] || "prev-page"

link_to "Previous", url_for(page: collection.prev_page), class: options[:previous_class] || "prev-page"

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:08:14Z

app/helpers/pagination_helper.rb

+
+  def link_to_next_page(collection, options)
+    unless collection.last_page?
+      link_to 'Next', url_for(page: collection.next_page), class: options[:next_class] || "next-page"


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

link_to 'Next', url_for(page: collection.next_page), class: options[:next_class] || "next-page"

link_to "Next", url_for(page: collection.next_page), class: options[:next_class] || "next-page"

forsbergplustwo · 2024-02-03T19:08:14Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: (page == collection.current_page ? options[:active_class] : options[:page_class])


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: (page == collection.current_page ? options[:active_class] : options[:page_class])

link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class])

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:08:14Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:08:14Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get 'shops/index/(:page)', to: "shops#index", as: 'shops_index'

forsbergplustwo · 2024-02-03T19:08:14Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get 'shops/index/(:page)', to: 'shops#index', as: "shops_index"

forsbergplustwo · 2024-02-03T19:09:20Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'

forsbergplustwo · 2024-02-03T19:09:20Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: "shops#index", as: 'shops_index'

forsbergplustwo · 2024-02-03T19:09:20Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: 'shops#index', as: "shops_index"

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:09:34Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: (page == collection.current_page ? options[:active_class] : options[:page_class])


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: (page == collection.current_page ? options[:active_class] : options[:page_class])

link_to page, url_for(page: page), class: (((page == collection.current_page ? options[:active_class] : options[:page_class]))

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:09:34Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: "shops#index", as: 'shops_index'

forsbergplustwo · 2024-02-03T19:09:34Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'

get "shops/index/(:page)", to: 'shops#index', as: "shops_index"

forsbergplustwo · 2024-02-03T19:09:38Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class]))


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class]))

link_to page, url_for(page: page), class: (((page == collection.current_page ? options[:active_class] : options[:page_class]))

forsbergplustwo · 2024-02-03T19:10:40Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class]))


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class]))

link_to page, url_for(page: page), class: ((((page == collection.current_page ? options[:active_class] : options[:page_class])))

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:10:40Z

config/routes.rb

@@ -18,7 +18,7 @@
  resources :summarys, only: [] do
    collection do
      get :monthly, to: "summarys/monthly#index"
-      get :shop, to: "summarys/shop#index"
+      get "shops/index/(:page)", to: 'shops#index', as: "shops_index"


[standard] <Style/StringLiterals> _{reported by reviewdog 🐶}
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Suggested change

get "shops/index/(:page)", to: 'shops#index', as: "shops_index"

get "shops/index/(:page)", to: "shops#index", as: "shops_index"

forsbergplustwo · 2024-02-03T19:10:56Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: (((page == collection.current_page ? options[:active_class] : options[:page_class])))


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: (((page == collection.current_page ? options[:active_class] : options[:page_class])))

link_to page, url_for(page: page), class: ((((page == collection.current_page ? options[:active_class] : options[:page_class])))

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

forsbergplustwo · 2024-02-03T19:11:46Z

app/helpers/pagination_helper.rb

+    end_page = [collection.current_page + options[:page_range], collection.total_pages].min
+
+    (start_page..end_page).map do |page|
+      link_to page, url_for(page: page), class: ((((page == collection.current_page ? options[:active_class] : options[:page_class]))))


[standard] <Style/TernaryParentheses> _{reported by reviewdog 🐶}
Use parentheses for ternary expressions with complex conditions.

Suggested change

link_to page, url_for(page: page), class: ((((page == collection.current_page ? options[:active_class] : options[:page_class]))))

link_to page, url_for(page: page), class: (((((page == collection.current_page ? options[:active_class] : options[:page_class]))))

sweep-ai bot added 4 commits February 3, 2024 18:58

feat: Implement pagination on 'Shop Summary' page

95f238d

feat: Add pagination controls to Shop Summary page

c5f6448

feat: Add custom pagination helper for enhanced UI

8d4915f

feat: Updated config/routes.rb

b80e3a3

sweep-ai bot added the sweep label Feb 3, 2024

sweep-ai bot mentioned this pull request Feb 3, 2024

Pagination Missing on "Shop Summary" Merchant Table #96

Open

8 tasks

forsbergplustwo reviewed Feb 3, 2024

View reviewed changes

sweep-ai bot added 3 commits February 3, 2024 19:09

feat: Updated app/helpers/pagination_helper.rb

2a50605

feat: Updated config/routes.rb

37e9dff

feat: Updated app/helpers/pagination_helper.rb

85f0288

forsbergplustwo reviewed Feb 3, 2024

View reviewed changes

sweep-ai bot added 2 commits February 3, 2024 19:10

feat: Updated config/routes.rb

915d521

feat: Updated app/helpers/pagination_helper.rb

3e2f97a

forsbergplustwo reviewed Feb 3, 2024

View reviewed changes

sweep-ai bot added 2 commits February 3, 2024 19:11

feat: Updated app/helpers/pagination_helper.rb

3803211

feat: Updated app/helpers/pagination_helper.rb

31de116

forsbergplustwo reviewed Feb 3, 2024

View reviewed changes

forsbergplustwo closed this Feb 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sweep: Pagination Missing on "Shop Summary" Merchant Table (✓ Sandbox Passed) #100

Sweep: Pagination Missing on "Shop Summary" Merchant Table (✓ Sandbox Passed) #100

sweep-ai bot commented Feb 3, 2024 •

edited

Loading

sweep-ai bot commented Feb 3, 2024

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

forsbergplustwo Feb 3, 2024

sweep-ai bot Feb 3, 2024 •

edited

Loading

forsbergplustwo Feb 3, 2024

	link_to 'Previous', url_for(page: collection.prev_page), class: options[:previous_class] \|\| "prev-page"
	link_to "Previous", url_for(page: collection.prev_page), class: options[:previous_class] \|\| "prev-page"

	link_to 'Next', url_for(page: collection.next_page), class: options[:next_class] \|\| "next-page"
	link_to "Next", url_for(page: collection.next_page), class: options[:next_class] \|\| "next-page"

	link_to page, url_for(page: page), class: (page == collection.current_page ? options[:active_class] : options[:page_class])
	link_to page, url_for(page: page), class: ((page == collection.current_page ? options[:active_class] : options[:page_class])

	get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'
	get "shops/index/(:page)", to: 'shops#index', as: 'shops_index'

	get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'
	get 'shops/index/(:page)', to: "shops#index", as: 'shops_index'

	get 'shops/index/(:page)', to: 'shops#index', as: 'shops_index'
	get "shops/index/(:page)", to: "shops#index", as: 'shops_index'

Sweep: Pagination Missing on "Shop Summary" Merchant Table (✓ Sandbox Passed) #100

Sweep: Pagination Missing on "Shop Summary" Merchant Table (✓ Sandbox Passed) #100

Conversation

sweep-ai bot commented Feb 3, 2024 • edited Loading

PR Feedback: 👎

Description

Summary

💡 To get Sweep to edit this pull request, you can:

sweep-ai bot commented Feb 3, 2024

Rollback Files For Sweep

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sweep-ai bot Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

🚀 Wrote Changes

Choose a reason for hiding this comment

sweep-ai bot commented Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading

sweep-ai bot Feb 3, 2024 •

edited

Loading