dataModelObjects and conversionMetadata in templates #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is currently in pilot in Winter '24 release.
This feature is currently in pilot in Winter '24 release. This includes schema support, and validation, code-completion, quick fix and definition support on the `dataset` field.
smithgp
commented
Sep 15, 2023
| @@ -35,42 +34,3 @@ export class LayoutVariableCodeActionProvider extends VariableRefCodeActionProvi | |||
| return undefined; | |||
| } | |||
| } | |||
|
|
|||
| /** Provide quick fixes for unrecognized variable tile keys in layout.json's. */ | |||
There was a problem hiding this comment.
I refactored this into shared code in util/actions.ts below.
| @@ -367,15 +400,6 @@ export class TemplateDirEditing extends Disposable { | |||
| providedCodeActionKinds: LayoutVariableCodeActionProvider.providedCodeActionKinds | |||
| }), | |||
|
|
|||
| // hookup quick fixes for variable tile keys in layout.json's | |||
| vscode.languages.registerCodeActionsProvider( | |||
There was a problem hiding this comment.
This is now handled by the common FuzzyMatchCodeActionProvider registration above.
aarondailsf2023
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds optional
conversionMetadatafield todatasetFilesin template-info.json, including validation, code-completion, and definition (CMD+click) support to the related file.Add
dataModelObjectsto template-info.json, including validation, and code-completion, quick-fix, and definition support on thedatasetfield.These features are currently in pilot in Winter '24 release.
Also, unrelated, fixes a json schema issue with
namebeing required inbackgroundImages in layout.json.What issues does this PR fix or reference?
Fixes @W-14039520.