Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(GitHub): bump gradle/actions from 3 to 4 #11

Closed
wants to merge 1 commit into from
Closed

ci(GitHub): bump gradle/actions from 3 to 4 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
${{ runner.os }}-kmp-

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Breaking changes detected in Gradle setup action v4.

The release notes for version 4.0.0 of the Gradle setup action mention "Deprecations and breaking changes." It is crucial to review these notes in detail to understand the specific changes and assess their impact on your workflow. Please ensure compatibility and make necessary adjustments to accommodate these changes.

  • Review the release notes for Gradle setup action v4.0.0 for detailed information on breaking changes and deprecated features.
Analysis chain

LGTM! The upgrade to Gradle setup action v4 is a good move.

The upgrade from version 3 to version 4 of the Gradle setup action is likely to bring improvements such as:

  • Enhanced performance
  • Additional features
  • Bug fixes

This will optimize the build process and ensure better compatibility with newer Gradle versions. The existing cache management parameters remain unchanged, which ensures that the workflow continues to effectively manage caching, particularly addressing the noted performance issues on Windows environments.

Please verify if the upgrade has any breaking changes or compatibility issues by checking the release notes and running the following script:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any mentions of breaking changes or compatibility issues in the release notes.

# Test: Search for breaking changes or compatibility issues in the release notes. Expect: No concerning mentions found.
gh release view v4.0.0 --repo gradle/actions | rg -i "breaking|compatibility"

Length of output: 116

with:
gradle-home-cache-cleanup: true
cache-disabled: ${{ matrix.os == 'windows' }} # super slow on Windows.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
java-version: 22

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-disabled: true
cache-read-only: true
Expand Down
2 changes: 2 additions & 0 deletions fluxo-io-rad/detekt-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
<ID>ForbiddenComment:RandomAccessFileRad.kt$// TODO: Try to avoiding the excessive `filePointer` usages.</ID>
<ID>ForbiddenComment:ReflectionUtils.kt$// TODO: Complex search as for dynamic methods ?</ID>
<ID>ForbiddenComment:StreamFactoryRad.kt$// FIXME: Use own BufferedInputStream heir to gain better random access performance?</ID>
<ID>NoNameShadowing:RandomAccessDataByteBufferTest.kt$RadByteBufferAccessorTest.Companion${ it.put(BYTES).flipCompat() }</ID>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve tracking the name shadowing issue, but advise resolving it.

The addition of the entry to track the NoNameShadowing issue in RandomAccessDataByteBufferTest.kt is approved. However, it's advisable to resolve the name shadowing issue to improve code clarity and avoid potential bugs.

<ID>UnnecessaryAbstractClass:AbstractRandomAccessDataTest.kt$AbstractRandomAccessDataTest$AbstractRandomAccessDataTest</ID>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve tracking the unnecessary abstract class issue, but advise reviewing its necessity.

The addition of the entry to track the UnnecessaryAbstractClass issue in AbstractRandomAccessDataTest.kt is approved. However, it's advisable to review the necessity of the abstract class and refactor the code if it's not serving its intended purpose. This can improve the code structure and maintainability.

</CurrentIssues>
</SmellBaseline>
31 changes: 31 additions & 0 deletions fluxo-io-rad/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.6.0-alpha08" type="baseline" client="gradle" dependencies="false" name="AGP (8.5.0)" variant="all" version="8.6.0-alpha08">

<issue
id="AndroidGradlePluginVersion"
message="A newer version of com.android.library than 8.5.0 is available: 8.6.0. (There is also a newer version of 8.5.𝑥 available, if upgrading to 8.6.0 is difficult: 8.5.2)">
<location
file="$HOME/work/fluxo-io/fluxo-io/gradle/libs.versions.toml"
line="43"
column="25"/>
</issue>
Comment on lines +4 to +11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve tracking the Android Gradle Plugin version issue, but advise updating to the latest version.

The addition of the entries to track the AndroidGradlePluginVersion issue in the new lint-baseline.xml file is approved. However, it's advisable to update the Android Gradle Plugin to the latest version (8.6.0 or 8.5.2) in the gradle/libs.versions.toml file at the locations indicated by the lint issue. This will ensure that the project is using the latest features and improvements provided by the Android Gradle Plugin.

Also applies to: 13-20, 22-29


<issue
id="AndroidGradlePluginVersion"
message="A newer version of com.android.library than 8.5.0 is available: 8.6.0. (There is also a newer version of 8.5.𝑥 available, if upgrading to 8.6.0 is difficult: 8.5.2)">
<location
file="$HOME/work/fluxo-io/fluxo-io/gradle/libs.versions.toml"
line="43"
column="25"/>
</issue>

<issue
id="AndroidGradlePluginVersion"
message="A newer version of com.android.library than 8.5.0 is available: 8.6.0. (There is also a newer version of 8.5.𝑥 available, if upgrading to 8.6.0 is difficult: 8.5.2)">
<location
file="$HOME/work/fluxo-io/fluxo-io/gradle/libs.versions.toml"
line="43"
column="25"/>
</issue>

</issues>