Update Terraform version in CI #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
souleb
approved these changes
Apr 23, 2024
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
swade1987
reviewed
Apr 23, 2024
| - name: Generate docs | ||
| run: make docs | ||
| - name: Check if working tree is dirty | ||
| run: | | ||
| if [[ $(git diff --stat) != '' ]]; then | ||
| git diff | ||
| echo 'run make docs and commit changes' | ||
| echo "run 'make build docs' and commit changes" |
There was a problem hiding this comment.
Shouldn't this be make build && make docs
There was a problem hiding this comment.
No, Make targets are made to be chained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: