Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting embedded_manifest to true and repo visibility to private. #666

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Setting embedded_manifest to true and repo visibility to private. #666

merged 1 commit into from
Apr 23, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented Apr 22, 2024 •
edited
Loading

Description

Setting embedded_manifest to true and repo visibility to private.

It also fixes issues running make testmacos locally.

Motivation and Context

Fixes #665

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/testing Testing related issues and pull requests labels Apr 22, 2024
@swade1987
Setting embedded_manifest to true and repo visibility to private.
d05e881 
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
stefanprodan
stefanprodan approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 🏅

@stefanprodan stefanprodan merged commit 3edd381 into fluxcd:main Apr 23, 2024
21 checks passed
@fluxcd fluxcd locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests area/testing Testing related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all examples and set embedded_manifests = true
2 participants
@swade1987 @stefanprodan