Solve ProjectionPredicate during normalization
#830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilehmann
reviewed
Oct 1, 2024
nilehmann
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@ranjitjhala, looks good to merge (modulo small comments), but I'm not sure if it fully solves #829. That one involves a FnOnce::Otput projection on a function pointer and I have the impression that the implementation of FnOnce for function pointers is built-in, so I'm not sure how that plays out. It may be ok though. That's an orthogonal issue though, just want to make sure we are not closing #829 if it's not fully solved.
| } | ||
|
|
||
| fn ctor_for_param(&mut self, _param_ty: rustc_middle::ty::ParamTy) -> super::SubsetTyCtor { | ||
| todo!() |
There was a problem hiding this comment.
Suggested change
| todo!() | |
| tracked_span_bug!() |
| } | ||
|
|
||
| fn region_for_param(&mut self, _ebr: rustc_middle::ty::EarlyParamRegion) -> Region { | ||
| todo!() |
There was a problem hiding this comment.
Suggested change
| todo!() | |
| tracked_span_bug!() |
| } | ||
|
|
||
| fn expr_for_param_const(&self, _param_const: rustc_middle::ty::ParamConst) -> Expr { | ||
| todo!() |
There was a problem hiding this comment.
Suggested change
| todo!() | |
| tracked_span_bug!() |
| } | ||
|
|
||
| fn const_for_param(&mut self, _param: &Const) -> Const { | ||
| todo!() |
There was a problem hiding this comment.
Suggested change
| todo!() | |
| tracked_span_bug!() |
Co-authored-by: Nico Lehmann <nico.lehmannm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829