Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try catch request cache thumbnail #975

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

masewo
Copy link
Contributor

@masewo masewo commented Aug 21, 2023

App crashes when photo_manager tries to request a cache thumbnail for a broken image file, like this one:
https://drive.google.com/file/d/1-8C4w2fhbHh2EmsJPF2SN0de3NiTNiCN/view?usp=drivesdk

Catch the thrown exception so that the main app does not crash.

Copy link
Member

@CaiJingLong CaiJingLong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaiJingLong CaiJingLong merged commit db972a1 into fluttercandies:main Aug 23, 2023
10 checks passed
@CaiJingLong CaiJingLong added this to the 2.7.2 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants