Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18… #552

Merged
merged 4 commits into from
Sep 21, 2024
Merged

feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18… #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d95e590
feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18…
floydspace Sep 21, 2024
bb20160
fix: update esbuild-node-externals to version 1.14.0
floydspace Sep 21, 2024
bdc1756
fix: esbuild-node-externals breaking change usage
floydspace Sep 21, 2024
736e67f
test: fix test failing in node 20 and higher
floydspace Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14, 16, 18]
node-version: [18, 20, 22]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14, 16, 18]
node-version: [18, 20, 22]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -28,7 +28,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npx semantic-release
env:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ The following `esbuild` options are automatically set.
| `entryPoints` | N/A | Cannot be overridden |
| `outDir` | N/A | Cannot be overridden |
| `platform` | `'node'` | Set `format` to `esm` to enable ESM support |
| `target` | `'node16'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
| `target` | `'node18'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
| `watch` | N/A | Cannot be overridden |

#### Packager Options
Expand Down
2 changes: 1 addition & 1 deletion e2e/__snapshots__/complete.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ exports[`complete 5`] = `
"Arn",
],
},
"Runtime": "nodejs12.x",
"Runtime": "nodejs18.x",
"Timeout": 6,
},
"Type": "AWS::Lambda::Function",
Expand Down
4 changes: 2 additions & 2 deletions e2e/__snapshots__/individually.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ exports[`individually 6`] = `
"Arn",
],
},
"Runtime": "nodejs12.x",
"Runtime": "nodejs18.x",
"Timeout": 6,
},
"Type": "AWS::Lambda::Function",
Expand Down Expand Up @@ -295,7 +295,7 @@ exports[`individually 6`] = `
"Arn",
],
},
"Runtime": "nodejs12.x",
"Runtime": "nodejs18.x",
"Timeout": 6,
},
"Type": "AWS::Lambda::Function",
Expand Down
2 changes: 1 addition & 1 deletion e2e/__snapshots__/minimal.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14227,7 +14227,7 @@ exports[`minimal 5`] = `
"Arn",
],
},
"Runtime": "nodejs12.x",
"Runtime": "nodejs18.x",
"Timeout": 6,
},
"Type": "AWS::Lambda::Function",
Expand Down
2 changes: 1 addition & 1 deletion examples/complete/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@types/node": "^18.7.21",
"esbuild": "^0.20.0",
"esbuild": "^0.23.0",
"serverless": "^3.22.0",
"serverless-esbuild": "file:../..",
"serverless-offline": "^10.2.1",
Expand Down
2 changes: 1 addition & 1 deletion examples/complete/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ custom:

provider:
name: aws
runtime: nodejs12.x
runtime: nodejs18.x

functions:
validateIsin:
Expand Down
2 changes: 1 addition & 1 deletion examples/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"devDependencies": {
"@types/lodash": "4.14.185",
"@types/node": "^18.7.21",
"esbuild": "^0.20.0",
"esbuild": "^0.23.0",
"serverless": "^3.22.0",
"serverless-esbuild": "file:../..",
"serverless-offline": "^10.2.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/config/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ package:

provider:
name: aws
runtime: nodejs12.x
runtime: nodejs18.x

custom:
esbuild:
Expand Down
2 changes: 1 addition & 1 deletion examples/individually/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"devDependencies": {
"@types/lodash": "4.14.185",
"@types/node": "^18.7.21",
"esbuild": "^0.20.0",
"esbuild": "^0.23.0",
"serverless": "^3.22.0",
"serverless-esbuild": "file:../..",
"serverless-offline": "^10.2.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/individually/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ package:

provider:
name: aws
runtime: nodejs12.x
runtime: nodejs18.x

custom:
esbuild:
Expand Down
2 changes: 1 addition & 1 deletion examples/minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@types/node": "^18.7.21",
"esbuild": "^0.20.0",
"esbuild": "^0.23.0",
"serverless": "^3.22.0",
"serverless-esbuild": "file:../..",
"serverless-offline": "^10.2.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/minimal/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ plugins:

provider:
name: aws
runtime: nodejs12.x
runtime: nodejs18.x

functions:
validateIsin:
Expand Down
Loading
Loading