Support for nbb #188
Draft
Support for nbb #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was simple to remove (assuming it works) and ring buffer isn't compatible with nbb.
needed for nbb
jpmonettas
reviewed
Nov 27, 2024
There was a problem hiding this comment.
I added a couple of comments regarding removing ring-buffer.
Apart from that, what I'm not sure is about how instrumentation would work for nbb since if I understand correctly it doesn't use Clojure or ClojureScript for compilation, it uses SCI to interpret Clojure right?
| @@ -26,11 +25,11 @@ | |||
| (rt-events/publish-event! (rt-events/make-last-evals-update-event last-evals-refs)))) | |||
|
|
|||
| (defn clear-outputs [] | |||
| (reset! *last-evals-results (ring-buffer 10)) | |||
| (reset! *last-evals-results []) | |||
There was a problem hiding this comment.
The reason I added a ring-buffer here is because the ring-buffer library was already here for other functionality (see my comment below) and I think it looks cleaner
| (defn grep-coll | ||
|
|
||
| "Search over coll with pred, when it matches returns the | ||
| A elements before and the B elements after" | ||
|
|
||
| [coll A B pred] | ||
| (loop [elems-before (ring-buffer A) | ||
| (loop [elems-before [] |
There was a problem hiding this comment.
I brought a ring-buffer for this only for performance reasons. If we change it like the proposed time will grow linearly on A, making it too slow for the current case.
On my box :
(def col (doall (repeat 10000000 :elem)))
(time (grep-coll col 1000 1 (constantly false))) ; ~ 1 sec
(time (grep-coll-without-ring-buffer col 1000 1 (constantly false))) ; ~ 207 sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a WIP