-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI prototype #52
Merged
Merged
Web UI prototype #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into web-ui-prototype
…into web-ui-prototype
Moved JS code from script section of index.html to index.js, and added GIFs to the popup tutorial.
Lexseal
requested review from
shishir03,
PeterNguyen4,
akann0 and
Justin6Liu
September 20, 2023 06:35
Visit the preview URL for this PR (updated for commit 4aa579d): https://flapjs--pr52-web-ui-prototype-cafcuez9.web.app (expires Tue, 03 Oct 2023 23:03:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 55816c1f4a2c8918b2b2b8ee41ad5acf0bad40a2 |
Took a quick look at it and it definitely looks a lot better! Haven't comprehensively tested for any bugs but so far it looks good |
…into web-ui-prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope your summer is going well! Thank you so much to Aaron, Justin, and Peter for making such a nice-looking interface! I have done some minor tweaking with the CSS, some bug fixes, and finally breaking up the files for maintainability. Please take a minute to try the temporary website and leave suggestions! I know Peter has been working on additional UI elements so feel free to keep adding commits here!