-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm_resources_manager] use cache instead of a plain client #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
2 times, most recently
from
October 17, 2024 13:31
b9bce8d
to
f646dd5
Compare
miklezzzz
changed the title
Resource informer with cache
[helm_resources_manager] use cache instead of a simple client
Oct 17, 2024
miklezzzz
changed the title
[helm_resources_manager] use cache instead of a simple client
[helm_resources_manager] use cache instead of a plain client
Oct 17, 2024
yalosev
reviewed
Oct 18, 2024
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
4 times, most recently
from
October 21, 2024 15:23
9e509c6
to
024f1d6
Compare
yalosev
reviewed
Oct 21, 2024
yalosev
reviewed
Oct 21, 2024
yalosev
reviewed
Oct 21, 2024
yalosev
reviewed
Oct 21, 2024
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
from
October 22, 2024 06:37
65c9434
to
38cd01e
Compare
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
from
October 22, 2024 12:54
8731217
to
b2309ab
Compare
ldmonster
reviewed
Oct 23, 2024
ldmonster
reviewed
Oct 23, 2024
ldmonster
reviewed
Oct 23, 2024
ldmonster
reviewed
Oct 23, 2024
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
from
October 23, 2024 16:43
b2309ab
to
6e97384
Compare
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
miklezzzz
force-pushed
the
resource-informer-use-cache
branch
from
October 23, 2024 16:44
6e97384
to
9a82158
Compare
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
ldmonster
approved these changes
Oct 24, 2024
yalosev
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, helm resources manager creates a resources monitor for every enabled module that has a helm release. In its turn, a resource monitor periodically checks whether all the resource of the corresponding helm release are presented in the cluster. These checks are performed by retrieving partial metadata for every object of the release via List operation. The main gist of the PR is to get objects' metadata not from the cluster API directly, but rather from the cache, decreasing amount of List operations and speeding up some of the operations related to helm releases (checking if a helm release should be applied, running periodic checks for absent resources).
What this PR does / why we need it
heritage=addon-operator
by default, yet configurable) to every resource the operator deploys (see helm post-renderer functionality).Special notes for your reviewer