Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scheduler and provide get-update-by-extender method #501

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

miklezzzz
Copy link
Contributor

@miklezzzz miklezzzz commented Aug 28, 2024

Overview

  1. Fixed some erroneous logic in the scheduler's logic when filtering modules by a terminator extender.
  2. Provided a couple of methods to get info which extender actually enabled/disabled a module.

What this PR does / why we need it

  1. To fix the aforementioned bug in the scheduler's logic.
  2. To be able to reflect in modules' status why modules were enabled/disabled.

Special notes for your reviewer

@miklezzzz miklezzzz added bug Something isn't working enhancement New feature or request labels Aug 28, 2024
@miklezzzz miklezzzz self-assigned this Aug 28, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz marked this pull request as ready for review August 29, 2024 09:06
@miklezzzz miklezzzz marked this pull request as draft August 29, 2024 09:43
@miklezzzz miklezzzz marked this pull request as ready for review August 29, 2024 09:47
@yalosev yalosev merged commit b5cdd86 into main Aug 29, 2024
8 checks passed
@yalosev yalosev deleted the fix-scheduler-and-provide-get-update-by-extender-method branch August 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants