fix: allow even more complex bindings #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the outstanding problems is a two model mutli-bind where
B.K_1 -> A.K_1
B.K_2 -> A.K_2
A.K_2 -> A.K_1
in which case the bindings for `B` might come out as index `[1, 2]`, but
`A` only has 1 parameter in its parameter vector, leading to index out
of bounds.
fjebaker
force-pushed
the
fergus/fix-binding
branch
from
9d42930
to
9e4616d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the outstanding problems is a two model mutli-bind where
in which case the bindings for
Bmight come out as index[1, 2], butAonly has 1 parameter in its parameter vector, leading to index out of bounds.