Convolutions #122
Merged
Convolutions #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a delta function model, which is in essence an alias to a very thin Gaussian. This can be at some point updated to a more faithful implementation, provided we find a good way of propagating gradients as the line moves through the domain. Intended use is for emission lines or as the basis for convolutions.
This wrapper can turn any AbstractSpectralModel into a convolutional model, and will remove additive normalisations if required. Convolution function is a modification of the Toeplitz matrix method, which performs the matrix multiplications without allocating the matrix. The benefit this has over, e.g., the FFT(W) method of taking convolutions, in that we can propagate gradients through the operation.
fjebaker
force-pushed
the
fergus/convolutions
branch
from
d13afb7
to
eab089e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.