fix: bind parameters in models with frozen parameters #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though the change is only really one functional line it took me ages to figure it out! |
|
Awesome! Thank you Andy. Just looking at why the CI is failing. fitting: Error During Test at /home/runner/work/SpectralFitting.jl/SpectralFitting.jl/test/runtests.jl:86
Got exception outside of a @test
LoadError: type PowerLaw has no field K_1Weird though because that method of freezing a parameter should be fine. Might be something else going on there, will quickly clone and see what I can find. |
|
Ah I see the problem. |
|
I've just fixed it. Classic problem of it working in the REPL when the commands were not executed in order. |
|
Is this PR ready for review / merging? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binding parameters we should only be considering free parameters in the model, not all parameters. Updated _get_index_of_symbol in binding.jl to skip frozen parameters.
Added a couple of test cases to check this works. Could probably add more tests.