Update example app #64
Conversation
…k if it simulator, pass user name to room screen
…ast notification use instead simple alert
| const toggleSwitchCamera = () => { | ||
| setCurrentCamera( | ||
| availableCameras.current.find( | ||
| (dev) => dev.isFrontFacing !== currentCamera?.isFrontFacing, |
example/utils/deviceUtils.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| import * as Device from 'expo-device'; | |||
There was a problem hiding this comment.
import {isDevice} from 'expo-device';
example/types/ComponentLabels.ts
Outdated
| USE_ROOM_MANAGER_TAB: 'use_room_manager_tab', | ||
| USE_TOKEN_TAB: 'use_token_tab', |
There was a problem hiding this comment.
| USE_ROOM_MANAGER_TAB: 'use_room_manager_tab', | |
| USE_TOKEN_TAB: 'use_token_tab', | |
| ROOM_MANAGER_TAB: 'room_manager_tab', | |
| TOKEN_TAB: 'token_tab', |
This sounds more natural.
| @@ -120,7 +129,7 @@ const RoomScreen = ({ navigation }: Props) => { | |||
| accessibilityLabel={SWITCH_CAMERA_BUTTON} | |||
| /> | |||
| <InCallButton | |||
| iconName={isScreencastOn ? 'share-off' : 'share'} | |||
| iconName={isScreencastOn ? 'share' : 'share-off'} | |||
There was a problem hiding this comment.
I think that for screensharing icons should be swapped. If screencast is off we suggest to share, if it is on we suggest to stop sharing.
There was a problem hiding this comment.
Idk. I've tested how it looks on other tools, probably we might need to use different icon set for sharing (instead of justo on/off). I would leave is as is for now, and improve it when we decide to visually update app.
example/screens/RoomScreen.tsx
Outdated
| @@ -91,10 +97,13 @@ const RoomScreen = ({ navigation }: Props) => { | |||
|
|
|||
| return ( | |||
| <SafeAreaView style={styles.container}> | |||
| {tracks.length > 0 ? ( | |||
| {tracks.length > 0 && !isIosSimulator ? ( | |||
There was a problem hiding this comment.
| {tracks.length > 0 && !isIosSimulator ? ( | |
| {tracks.length > 0 ? ( |
For video grid simulator condition is not necessary. It will display other peers video track.
| import { NoCameraView } from '../../components/NoCameraView'; | ||
| import { SoundOutputDevicesBottomSheet } from '../../components/SoundOutputDevicesBottomSheet'; | ||
| import VideoPreview from '../../components/VideoPreview'; | ||
| import { usePreventBackButton } from '../../hooks/usePreventBackButton'; |
There was a problem hiding this comment.
Maybe lets add path so import would look like:
import { usePreventBackButton } from '@hooks/usePreventBackButton';
There was a problem hiding this comment.
50/50 for adding additional project config to have 'nicer' imports. But we can improve directory structure to have separate folder with JS source (example/src/...)
Description
Describe your changes in detail.
Motivation and Context
Update the example application we want to make it easier to understand.
How has this been tested?
Tested that on Samsung Galaxy Z Fold 5, and iPhone 15 simulator.