Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-bpf: enable sol-get-sysvar syscall #154

Open
wants to merge 1 commit into
base: agave-v2.1.3
Choose a base branch
from

Conversation

buffalojoec
Copy link
Collaborator

Problem

The BPF version of Address Lookup Table depends on SolGetSysvar to read slot hash data. It should be activated if testing against the BPF version of Address Lookup Table.

Summary of Changes

If the core-bpf feature is active, and the program is the Address Lookup Table program, activate the feature.

Copy link
Contributor

@mjain-jump mjain-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally these features should just be passed in through the fuzzing input. the harness should not be setting any state that should be defined within the input protobuf message

@buffalojoec
Copy link
Collaborator Author

ideally these features should just be passed in through the fuzzing input. the harness should not be setting any state that should be defined within the input protobuf message

Makes sense. For now I'm going to wait on this change, but ideally any fixture that doesn't have the syscall feature enabled is never going to pass in the BPF version. Maybe we can figure out another way, like generating fixtures with the feature enabled?

@kbhargava-jump kbhargava-jump changed the base branch from agave-v2.1.0 to agave-v2.1.3 November 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants