Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction target #57

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Transaction target #57

merged 5 commits into from
Jul 3, 2024

Conversation

mjain-jump
Copy link
Collaborator

  • Add conformance support for debugging transactions
  • Abstract effects pruning logic

ravyu-jump
ravyu-jump requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ravyu-jump ravyu-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just need to fix the type inconsistencies (not sure if something like mypy would have caught this?)

src/test_suite/fixture_utils.py Show resolved Hide resolved
src/test_suite/instr/prune_utils.py Outdated Show resolved Hide resolved
src/test_suite/txn/prune_utils.py Outdated Show resolved Hide resolved
src/test_suite/fuzz_interface.py Outdated Show resolved Hide resolved
@mjain-jump mjain-jump merged commit 93a8b94 into main Jul 3, 2024
1 check passed
@mjain-jump mjain-jump deleted the mjain/txn-target branch July 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravyu-jump ravyu-jump ravyu-jump requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjain-jump @ravyu-jump