Skip to content

Commit

Permalink
tweak the participants header bar in the packets list
Browse files Browse the repository at this point in the history
- extract labels into locales
- rename to PacketsParticipantsBar
- add bottom border and box shadow to the header bar
- change proposed labels to: Actors (Server) and Toolbox (Client)
  • Loading branch information
rpl committed Jul 17, 2015
1 parent 36060f8 commit cce12b6
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
5 changes: 5 additions & 0 deletions chrome/locale/en-US/inspector.properties
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,8 @@ rdpInspector.menu.File=File
rdpInspector.menu.Options=Options
rdpInspector.cmd.load=Load
rdpInspector.cmd.save=Save

# LOCALIZATION NOTE (rdpInspector.label.serverParticipant, rdpInspector.label.clientParticipant):
# Labels for the participant header bar in the packets panel main area.
rdpInspector.label.serverParticipant=Actors
rdpInspector.label.clientParticipant=Toolbox
19 changes: 11 additions & 8 deletions data/inspector/components/packets-panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,32 +19,35 @@ const { Splitter } = require("./splitter");
// Shortcuts
const { DIV, SPAN } = Reps.DOM;

var PacketsDirectionsBar = React.createClass({
/** @lends PacketsDirectionsBar */
var PacketsParticipantsBar = React.createClass({
/** @lends PacketsParticipantsBar */

displayName: "PacketsDirectionsBar",
displayName: "PacketsParticipantsBar",

render: function() {
return DIV({
id: "packetsDirectionsBar",
id: "packetsParticipantsBar",
style: {
position: "relative",
height: "24px"
height: "24px",
borderBottom: "1px solid #aaaaaa",
boxShadow: "0px 2px 2px 0px #aaaaaa",
zIndex: "1000"
}
}, SPAN({ style: {
position: "absolute",
top: "0px",
left: "10px",
fontWeight: "bold",
fontSize: "1.2em"
}, key: "server"}, "Server"),
}, key: "serverParticipant"}, Locale.$STR("rdpInspector.label.serverParticipant")),
SPAN({ style: {
position: "absolute",
top: "0px",
right: "10px",
fontWeight: "bold",
fontSize: "1.2em"
}, key: "client"}, "Client")
}, key: "clientParticipant"}, Locale.$STR("rdpInspector.label.clientParticipant"))
);
}
});
Expand Down Expand Up @@ -72,7 +75,7 @@ var PacketsPanel = React.createClass({
packetCacheEnabled: this.props.packetCacheEnabled,
paused: this.props.paused
}),
React.createElement(PacketsDirectionsBar, {}),
React.createElement(PacketsParticipantsBar, {}),
PacketList({
data: this.props.packets,
actions: this.props.actions,
Expand Down

0 comments on commit cce12b6

Please sign in to comment.