Fix #18: Process all URLs instead of only /c/portal/login / ...logout. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…..logout. Servlet filter config now matches /*, but implementation keeps processing only /portal/login and /portal/logout.
… Login OP. Current content locale is guessed by servlet path of HttpRequest first and by request locale second, if the servlet path does not seem to contain a locale. The resulting value is appended to the auth request URL as parameter `ui_locales` according to http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest .
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
========================================
Coverage ? 3.82%
Complexity ? 4
========================================
Files ? 6
Lines ? 183
Branches ? 27
========================================
Hits ? 7
Misses ? 176
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servlet filter config now matches /*, but implementation keeps
processing only /portal/login and /portal/logout.