Add a bit of logging to mock runtime #1006

mriise · 2023-01-10T15:42:07Z

No description provided.

…d scripts (#504) * add devnet-m2-native network with associated features to build scripts * transitively activate m2-native on runtime * add devnet-m2-native bundle build target * fix output target for m2-native bundle * pacify clippy. * runtime: Cargo.toml sort dependencies. * Cargo.toml: point patches to master. * fix devnet-m2-bundle by propagating Cargo features. * add build preset / bundle configurations for wallaby and devnet-wasm. QoL finishing touches: - The 1:N network/features mapping in runtime/build.rs wasn't cutting it any longer. I expanded this data structure to M:N. - Added docs to runtime/build.rs. Co-authored-by: vyzo <vyzo@hackzen.org>

* adjust Wallaby parameters. - minimum consensus power is 16GiB. - short precommit challenge delay (10 epochs). * fix: minimum consensus power for wallaby Co-authored-by: Aayush <arajasek94@gmail.com>

Co-authored-by: Raúl Kripalani <raul@protocol.ai>

This change makes CI trigger whenever: - a pull request is opened/updated - a commit is pushed to `master` branch The main advantage of this setup is that it enables CI runs on PRs originating from forks.

cleanup opcode definition and resolution

- removes the explicit instruction array. - removes the undefined instructions. - removes the need for ordering instructions in a specific way. - ensures that we can't talk about invalid instructions.

* bump rust-toolchain to 1.63 [needed for const fn magic] * fix new clippy warnings, most changes is just adding `Eq` to derive, only others was avoiding reborrows and allowing a 'complex' type * change .err.expect to .expect_err, and dont bind to a unit value Co-authored-by: mriise <me@mriise.net>

Co-authored-by: Melanie Riise <me@mriise.net>

…pe (#547)

Fix compile when not compiling as a "fil actor" (e.g., for testing).

This change upgrades to the v4 bundler that _does not_ depend on the FVM to map actor types to IDs. Instead, it relies on the Type enum defined in this repo. This means new actor types can be added here without having to make changes in multiple places.

Avoid blake2b hashing in wasm Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

Co-authored-by: lyswifter <ly70835@163.com>

* Optimize test_vm get_actor Improves extend_sector_with_deals by 40% Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai> * Keep the cache across invocations Gives another 32% Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai> Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>

* refactor: move opcode handlers to appropriate modules. * implement BASEFEE opcode handler. * implement SELFBALANCE opcode handler. * EVM runtime: add an initial Address type that performs ID address masking. * EVM runtime: convert EVM errors to ActorErrors. * EVM runtime: commented selfdestruct. * EVM runtime: implement DIFFICULTY, NUMBER, COINBASE opcodes. * EVM runtime: add conversion from actor ID to masked address. Make CALLER, ADDRESS, ORIGIN use masked ID addresses. * remove TODO. * add comment. * fix clippy. * adjust test for ID address flag.

* move native precompiles to their own addresses with prefix 0xfe * fmt and remove some stale TODOs * fix review comments * comment style consisticy

* fix evm_delegate_call's caller bug * use Eth address for delegate call params instead of ID address * fmt, add test for delegatecall Co-authored-by: samuerio <853713419@qq.com>

* disable get-randomness precompile * only remove precompile

* Use system.send instead of system.rt.send to properly flush state before calling into another actor. This is needed since ext* opcodes can/will be called during initcode. Ext* calling self durin initcode must have _some_ state flushed in order to fetch it, system.send will flush empty bytecode hashes to state before send for us. * fmt & fix tests * add tests for ext size/hash in initcode * clippy * fix delegate_call test

update EAM to check for new reserved range for native precompiles addresses

* check that precompile address last byte/index is within range of precompile array to avoid panic * clippy

And add a bunch of tests.

* move error handling logic into call instead of from trait, remove unused CallActorError * use err instead of flattening to empty vec right away * fmt * add more logging to precompile calls * add test for empty failure * fmt

* account for null and native precompile address in eth to f4 address conversions * fmt & err message fix * be explicit about rejecting null address in EAM * add eam test for null address

Stebalien · 2023-01-10T17:05:16Z

Can we make this PR against master first? It's not FEVM specific.

anorth · 2023-01-10T18:32:34Z

This will only actually print anything for failed tests, right?

mriise · 2023-01-10T18:49:32Z

This will only actually print anything for failed tests, right?

Depends on the env value of RUST_LOG. Default though will only print error level. It will print on successful test if log level is high enough.

mriise · 2023-01-10T19:07:37Z

Can we make this PR against master first? It's not FEVM specific.

It's not FEVM specific necessarily true, but most of the methods that I am logging in this PR don't exist on master or depend on FEVM related changes.

I would rather make a new PR on master with similar changes than to try and adapt this one.

Stebalien · 2023-01-11T01:31:07Z

Unfortunately, if we don't make this PR against master first, we'll end up with annoying conflicts next time we try to merge master back into next.

It's not FEVM specific necessarily true, but most of the methods that I am logging in this PR don't exist on master or depend on FEVM related changes.

Most of them do, right?

Stebalien · 2023-01-11T01:32:07Z

The other part of this is that this isn't an EVM specific change, so it should have up-front weigh-in from the rest of the actors/lotus team. It's easier for them to do that on PRs against master (and it'll reduce the review overhead in the final merge).

Stebalien · 2023-01-11T02:03:30Z

Hm. Actually, this is a good time to port user_get_randomness_from_chain as well.

Stebalien · 2023-01-11T02:04:19Z

(it'll help reduce our load merging to master)

vyzo and others added 30 commits July 22, 2022 11:20

[m2 native] user actor installation (#491)

a87c640

Merge branch 'master' into next

9c42e56

[next] bump crates versions to 10.0.0-alpha.1 (#507)

c28b820

adjust Wallaby parameters. (#508)

cf78922

* adjust Wallaby parameters. - minimum consensus power is 16GiB. - short precommit challenge delay (10 epochs). * fix: minimum consensus power for wallaby Co-authored-by: Aayush <arajasek94@gmail.com>

basic EVM smart contract actor (#517)

36ec85a

Co-authored-by: Raúl Kripalani <raul@protocol.ai>

Integration origin from runtime context (#562)

0dc90b0

EVM: don't encode contract invocation output data (#565)

3f8e6f1

ci: change CI trigger to pull_request + push to master (#510)

b1ca8a1

This change makes CI trigger whenever: - a pull request is opened/updated - a commit is pushed to `master` branch The main advantage of this setup is that it enables CI runs on PRs originating from forks.

ci: run CI on next (#569)

fc1dfb9

EVM: cleanup opcode definition and resolution (#572)

2d2122f

cleanup opcode definition and resolution

feat: enum-based opcodes (#573)

8533873

- removes the explicit instruction array. - removes the undefined instructions. - removes the need for ordering instructions in a specific way. - ensures that we can't talk about invalid instructions.

wip jmptable based interpreter

c49f4e1

flesh out machine scaffolding

4b01f17

implement interpreter guts

5b3db72

reduce duplication, make everything run by a single macro

645bd71

rustfmt

7ea12d0

Add comment about safety of the unsafe block.

a7536b3

Co-authored-by: Melanie Riise <me@mriise.net>

remove redundant identifier names

5381035

fix clippy

e37886f

Duplicate fvm_shared::actor::builtin::Type into runtime::builtins::Ty…

65369ba

…pe (#547)

fix: non-fil-actor-compile (#571)

66c9826

Fix compile when not compiling as a "fil actor" (e.g., for testing).

feat: Avoid blake2b hashing in wasm (#577)

032067e

Avoid blake2b hashing in wasm Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

Change runtime resolve address to return an ActorID (#549)

97ff14e

Co-authored-by: lyswifter <ly70835@163.com>

Change runtime address parameters to a reference (#581)

422a48a

feat: update sdk & shared for TokenAmount and hashing changes (#588)

dcc6643

mriise and others added 14 commits December 22, 2022 12:45

EVM: Native precompile address fe prefix (#981)

e1ef665

* move native precompiles to their own addresses with prefix 0xfe * fmt and remove some stale TODOs * fix review comments * comment style consisticy

EVM: Pass original caller through to callee for Delegate Call (#994)

1fa3f34

* fix evm_delegate_call's caller bug * use Eth address for delegate call params instead of ID address * fmt, add test for delegatecall Co-authored-by: samuerio <853713419@qq.com>

EVM: Disable get-randomness precompile (#995)

f2514a5

* disable get-randomness precompile * only remove precompile

EAM: Check addresses for reserved range of native precompile (#997)

12e271a

update EAM to check for new reserved range for native precompiles addresses

EVM: Check that precompile address index is within bounds (#996)

3b31742

* check that precompile address last byte/index is within range of precompile array to avoid panic * clippy

Enable logging with MockRuntime (#985)

c2182a9

EVM: fix the stack underflow check on swap (#1000)

1d62c67

And add a bunch of tests.

EVM: Fix precompiles to output nothing on error (#998)

8473c52

* move error handling logic into call instead of from trait, remove unused CallActorError * use err instead of flattening to empty vec right away * fmt * add more logging to precompile calls * add test for empty failure * fmt

add Hyperspace testnet parameters and build config.

b6bf61c

makefile: fix all-bundles to cover hyperspace & wallaby.

93d940b

EVM: Allow Null Addresses to convert into f4 Addresses (#1003)

56339c2

* account for null and native precompile address in eth to f4 address conversions * fmt & err message fix * be explicit about rejecting null address in EAM * add eam test for null address

add a bit of logging to mock runtime

98815e4

move randomness logs a bit lower down

74f36e7

mriise changed the base branch from next to master January 10, 2023 18:56

mriise changed the base branch from master to next January 10, 2023 18:56

Stebalien force-pushed the next branch from 421855a to 8e82ef7 Compare July 24, 2023 19:36

Stebalien force-pushed the next branch 2 times, most recently from 0ae21b1 to c0599c4 Compare August 14, 2023 19:32

Stebalien force-pushed the fvm-next branch 3 times, most recently from 3c56111 to 96654e3 Compare September 28, 2023 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a bit of logging to mock runtime #1006

Add a bit of logging to mock runtime #1006

mriise commented Jan 10, 2023

Stebalien commented Jan 10, 2023

anorth commented Jan 10, 2023

mriise commented Jan 10, 2023

mriise commented Jan 10, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023

Add a bit of logging to mock runtime #1006

Are you sure you want to change the base?

Add a bit of logging to mock runtime #1006

Conversation

mriise commented Jan 10, 2023

Stebalien commented Jan 10, 2023

anorth commented Jan 10, 2023

mriise commented Jan 10, 2023

mriise commented Jan 10, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023

Stebalien commented Jan 11, 2023