Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penalty method for interfaces #918

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Penalty method for interfaces #918

merged 2 commits into from
Nov 12, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR implements the penalty method for interface discontinuities.

➕ Advantages

  • We can set Henry vs Sieverts which we can do with the change of variable or the mixed domain approach
  • Simple implementation compared to mixed domain approach

➖ Drawbacks

  • requires a penalty term that could grow to infinity

We could potentially have it as a flag of the other discontinuous class method="nitsche" or method="penalty"

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.49%. Comparing base (8c5a965) to head (a81b602).
Report is 3 commits behind head on fenicsx.

Files with missing lines Patch % Lines
src/festim/hydrogen_transport_problem.py 84.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #918      +/-   ##
===========================================
- Coverage    97.80%   97.49%   -0.32%     
===========================================
  Files           44       44              
  Lines         2142     2193      +51     
===========================================
+ Hits          2095     2138      +43     
- Misses          47       55       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 0769a6f into fenicsx Nov 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant