-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and Stepsize classes #616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #616 +/- ##
===========================================
+ Coverage 96.98% 97.47% +0.48%
===========================================
Files 13 16 +3
Lines 398 475 +77
===========================================
+ Hits 386 463 +77
Misses 12 12
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Proposed changes
With this change, users can directly alter the parameters of the solver: the absolute and relative tolerance, the maximum iterations and final time of a transient simulations. The stepsize will be defined in its own class stepsize as this will likely evolve to something very similar to festim in its current version (v0.11.0). Stepsize will be an attribute of F.Settings.
Usage:
and for stepsize:
Additional solver modifications can be made after the initialisation of the simulation for more niche cases:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...