Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirichlet boundary conditions #606

Closed
wants to merge 22 commits into from

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This is a second attempt at #602

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (2fc987a) 95.06% compared to head (7c9f710) 84.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##           fenicsx     #606       +/-   ##
============================================
- Coverage    95.06%   84.14%   -10.92%     
============================================
  Files            9       11        +2     
  Lines          223      347      +124     
============================================
+ Hits           212      292       +80     
- Misses          11       55       +44     
Files Coverage Δ
festim/__init__.py 69.56% <100.00%> (+2.89%) ⬆️
festim/hydrogen_transport_problem.py 97.63% <100.00%> (+0.22%) ⬆️
festim/boundary_conditions/dirichlet_bc.py 75.00% <75.00%> (ø)
festim/boundary_conditions/sieverts_bc.py 65.71% <65.71%> (ø)
festim/helpers.py 42.85% <28.57%> (-57.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin changed the title Dirichlet bcs generic Dirichlet boundary conditions Oct 17, 2023
@jhdark jhdark added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Oct 17, 2023
@RemDelaporteMathurin RemDelaporteMathurin deleted the dirichlet_bcs_generic branch November 3, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants