-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTX export capability #603
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #603 +/- ##
===========================================
+ Coverage 95.06% 95.83% +0.76%
===========================================
Files 9 10 +1
Lines 223 264 +41
===========================================
+ Hits 212 253 +41
Misses 11 11
☔ View full report in Codecov by Sentry. |
might be worth just updating the permeation tests to use this new vtx output too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
This implements a
VTXExport
class that exports fields as VTX.It takes a filename and a species or list of species as argument.
VTX files are readable with the MPI version of paraview.
Note: I opened an issue on the VTK repo to track progress on the development of a non-MPI VTX writer.
Usage
with HTransportProblem
Current limitations:
festim.Species
of list offestim.Species
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist