Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations #578

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Deprecations #578

merged 3 commits into from
Oct 4, 2023

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR deprecates component argument in InitialCondition and XDMFExports as it wasn't very much used.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e751955) 98.84% compared to head (edf9f7a) 99.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   98.84%   99.07%   +0.23%     
==========================================
  Files          56       56              
  Lines        2073     2058      -15     
==========================================
- Hits         2049     2039      -10     
+ Misses         24       19       -5     
Files Coverage Δ
festim/__init__.py 97.18% <100.00%> (ø)
festim/exports/xdmf_export.py 100.00% <ø> (+3.33%) ⬆️
festim/initial_condition.py 100.00% <100.00%> (+12.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably for the best

@RemDelaporteMathurin RemDelaporteMathurin merged commit 6088215 into main Oct 4, 2023
3 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the deprecations branch October 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate functions in favour of fields in XDMFExport Deprecate component in favour of field
2 participants