nested-parens, benchmarking, and rayon #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpallant
requested changes
Sep 21, 2022
There was a problem hiding this comment.
I like the exercise - it's an interesting problem and I like the way we iterate though various solutions.
I do have a question mark about leetcode.com though - I've not heard of them before, and given their benchmarking seems to have issues (0ms is not a useful result) I'm not 100% convinced it's worth tying this example to their website quite so tightly. To mention it in passing is probably fine though, as long as the exercise can be completed without reference to it (e.g. if it's offline, or re-organised, or whatever).
| // 👀 I can propagate that information along the `Vec`! 👀 | ||
| max_count = 👾👾👾; | ||
| } | ||
| // 👀 Oh right, gotta catch the other case in the `map` here 👀 |
There was a problem hiding this comment.
I don't understand this comment. What map?
pvdrz
requested changes
Sep 21, 2022
assignments/nested-parens.adoc
Outdated
| ---- | ||
|
|
||
| find the line where there is the maximum number of nested parentheses. | ||
| In the above example, it would be one line `5`, as the maximum nesting level is `3`. |
There was a problem hiding this comment.
Suggested change
| In the above example, it would be one line `5`, as the maximum nesting level is `3`. | |
| In the above example, it would be on line `5`, as the maximum nesting level is `3`. |
Co-authored-by: Jonathan Pallant <jonathan.pallant@ferrous-systems.com>
Co-authored-by: Jonathan Pallant <jonathan.pallant@ferrous-systems.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I present my first assignment.
I hope people like the WIP.