Split the build. #219
Merged
Split the build. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ferrous-systems-rust-training with
|
| Latest commit: |
b841a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a18637d9.ferrous-systems-rust-training.pages.dev |
| Branch Preview URL: | https://split-build.ferrous-systems-rust-training.pages.dev |
jonathanpallant
force-pushed
the
split-build
branch
from
b4f14ad
to
e68ef98
Compare
Now the examples has a job, and building the examples in Ferrocene has a job.
The QEMU examples need it because they objdump their binaries.
Because the build outputs for examples don't go into the release area.
jonathanpallant
force-pushed
the
split-build
branch
from
58d7f76
to
b841a33
Compare
|
Rebased |
|
I'm happy to see that all but the How can I know if these changes lead to a hanging job besides the wall time? |
miguelraz
previously approved these changes
Oct 18, 2024
|
I don't see anything hanging? |
|
ah, the branch rule is waiting for a job that no longer exists. Ugh, GHA is so annoying. I don't think I can fix that until this PR is merged. |
miguelraz
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the examples has a job, and building the examples in Ferrocene has a job.
This means third-parties who submit PRs can still pass most of the tests.