fix(python): multipart file upload parameter fixes, python core utility bugfix. #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt type when provided.
dsinghvi
approved these changes
Nov 19, 2024
fern-bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ty bugfix. (#5201) * fix(python): omitted body parameters should not be encoded during files construction. * fix(python): with_content_type should resolve to specified file content type when provided. * Update `test_file.py` and improve `with_content_type` definition. * Add docstring to with_content_type. * Update python sdk seed snapshots. * Minor fix; update `file-upload` seed test snapshot to include new changes. * Snapshot updates. * Snapshot updates. * Update snapshots. * Update ts and java snapshots. * update
eyw520
added a commit
that referenced
this pull request
Nov 19, 2024
* Remove `fetch-mock-jest` dependency. * chore(docs): add example of landing page (#5205) * add landing-page schema * add example of landing page * chore(docs): update example to VapiAI * fix(docs): use accesible linking practices --------- Co-authored-by: Danny Sheridan <83524670+dannysheridan@users.noreply.github.com> Co-authored-by: Deep Singhvi <deep@buildwithfern.com> * chore(docs): hidden, overview section (#5214) hidden, overview section Co-authored-by: fern-bot <info@buildwithfern.com> * chore(docs): initial restructuring (#5196) * initial restructuring * chore: update changelog --------- Co-authored-by: fern-bot <info@buildwithfern.com> Co-authored-by: chdeskur <chdeskur@users.noreply.github.com> * fix(python): multipart file upload parameter fixes, python core utility bugfix. (#5201) * fix(python): omitted body parameters should not be encoded during files construction. * fix(python): with_content_type should resolve to specified file content type when provided. * Update `test_file.py` and improve `with_content_type` definition. * Add docstring to with_content_type. * Update python sdk seed snapshots. * Minor fix; update `file-upload` seed test snapshot to include new changes. * Snapshot updates. * Snapshot updates. * Update snapshots. * Update ts and java snapshots. * update * Update seed snapshots. --------- Co-authored-by: Elissa Alarmani <91026581+elissa-alarmani@users.noreply.github.com> Co-authored-by: Danny Sheridan <83524670+dannysheridan@users.noreply.github.com> Co-authored-by: Deep Singhvi <deep@buildwithfern.com> Co-authored-by: Catherine Deskur <46695336+chdeskur@users.noreply.github.com> Co-authored-by: fern-bot <info@buildwithfern.com> Co-authored-by: chdeskur <chdeskur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two fixes:
with_content_type()where we resolved to default spec content-type rather than user-specified content-type value.