fix(cli): remove default float min max (#5258)

* use convertDouble for float conversion * update snapshot tests * update cli version * chore: update changelog --------- Co-authored-by: fern-bot <fern-bot@users.noreply.github.com>
fern-api · Nov 22, 2024 · a3a4c2f · a3a4c2f
1 parent df3f3fb
commit a3a4c2f
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 50 deletions.
diff --git a/fern/pages/changelogs/cli/2024-11-22.mdx b/fern/pages/changelogs/cli/2024-11-22.mdx
@@ -0,0 +1,4 @@
+## 0.45.0-rc54
+**`(internal):`** Removes errant minimum and maximums for 'float' types for docs.
+
+
diff --git a/packages/cli/cli/versions.yml b/packages/cli/cli/versions.yml
@@ -1,3 +1,10 @@
+- changelogEntry:
+    - summary: |
+        Removes errant minimum and maximums for 'float' types for docs.
+      type: internal
+  irVersion: 53
+  version: 0.45.0-rc54
+
 - changelogEntry:
     - summary: |
         Add support for the `smart-casing` flags in the IR commands.

diff --git a/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json b/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json
@@ -22,10 +22,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -111,10 +108,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -215,10 +209,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -371,10 +362,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -548,10 +536,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -565,10 +550,7 @@
                 "itemType": {
                   "type": "primitive",
                   "value": {
-                    "type": "double",
-                    "minimum": 2.2250738585072014e-308,
-                    "maximum": 1.7976931348623157e+308,
-                    "default": 0
+                    "type": "double"
                   }
                 }
               }
@@ -1507,10 +1489,7 @@
                         "itemType": {
                           "type": "primitive",
                           "value": {
-                            "type": "double",
-                            "minimum": 2.2250738585072014e-308,
-                            "maximum": 1.7976931348623157e+308,
-                            "default": 0
+                            "type": "double"
                           }
                         }
                       }
@@ -1701,10 +1680,7 @@
                         "itemType": {
                           "type": "primitive",
                           "value": {
-                            "type": "double",
-                            "minimum": 2.2250738585072014e-308,
-                            "maximum": 1.7976931348623157e+308,
-                            "default": 0
+                            "type": "double"
                           }
                         }
                       }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json
@@ -71,10 +71,7 @@
               "itemType": {
                 "type": "primitive",
                 "value": {
-                  "type": "double",
-                  "minimum": 2.2250738585072014e-308,
-                  "maximum": 1.7976931348623157e+308,
-                  "default": 0
+                  "type": "double"
                 }
               }
             }
@@ -244,10 +241,7 @@
                       "itemType": {
                         "type": "primitive",
                         "value": {
-                          "type": "double",
-                          "minimum": 2.2250738585072014e-308,
-                          "maximum": 1.7976931348623157e+308,
-                          "default": 0
+                          "type": "double"
                         }
                       }
                     }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/object.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/object.json
@@ -246,10 +246,7 @@
             "valueType": {
               "type": "primitive",
               "value": {
-                "type": "double",
-                "minimum": 2.2250738585072014e-308,
-                "maximum": 1.7976931348623157e+308,
-                "default": 0
+                "type": "double"
               }
             }
           },

diff --git a/packages/cli/register/src/ir-to-fdr-converter/convertTypeShape.ts b/packages/cli/register/src/ir-to-fdr-converter/convertTypeShape.ts
@@ -196,12 +196,7 @@ export function convertTypeReference(irTypeReference: Ir.types.TypeReference): F
                     float: () => {
                         // TODO: Add support for float types in FDR. We render them as double for now
                         // (they have the same JSON representation).
-                        return {
-                            type: "double",
-                            minimum: 2.2250738585072014e-308,
-                            maximum: 1.7976931348623157e308,
-                            default: 0.0
-                        };
+                        return convertDouble(primitive.v2);
                     },
                     double: () => {
                         return convertDouble(primitive.v2);