chore(go): Remove path dependency from @fern-api/go-dynamic-snippets (#…

…5284)

generators/commons/src/utils/getBasename.ts

@@ -0,0 +1,6 @@
+/**
+ * Returns the basename of the given path (e.g. "foo/bar/baz" -> "baz").
+ */
+export function getBasename(path: string): string {
+    return path.split("/").pop() ?? "";
+}

generators/commons/src/utils/index.ts

@@ -1,3 +1,4 @@
+export { getBasename } from "./getBasename";
 export { getPackageName } from "./getPackageName";
 export { getSdkVersion } from "./getSdkVersion";
 export { parseGeneratorConfig } from "./parseGeneratorConfig";

generators/go-v2/ast/package.json

@@ -34,6 +34,7 @@
     "zod": "^3.22.3"
   },
   "devDependencies": {
+    "@fern-api/core-utils": "workspace:*",
     "@fern-api/fs-utils": "workspace:*",
     "@fern-api/generator-commons": "workspace:*",
     "@fern-fern/ir-sdk": "^53.21.0",

generators/go-v2/ast/src/ast/MethodInvocation.ts

@@ -1,5 +1,4 @@
 import { AstNode } from "./core/AstNode";
-import { UnnamedArgument } from "@fern-api/generator-commons";
 import { Writer } from "./core/Writer";
 import { writeArguments } from "./utils/writeArguments";
 

generators/go-v2/ast/src/ast/Struct.ts

@@ -1,7 +1,5 @@
 import { AstNode } from "./core/AstNode";
 import { Writer } from "./core/Writer";
-import { CodeBlock } from "./CodeBlock";
-import { Parameter } from "./Parameter";
 import { Field } from "./Field";
 import { Method } from "./Method";
 import { Comment } from "./Comment";

generators/go-v2/ast/src/ast/core/Writer.ts

@@ -1,7 +1,5 @@
-import { AbstractWriter, NopFormatter } from "@fern-api/generator-commons";
+import { AbstractFormatter, AbstractWriter, getBasename, NopFormatter } from "@fern-api/generator-commons";
 import { BaseGoCustomConfigSchema } from "../../custom-config/BaseGoCustomConfigSchema";
-import path from "path";
-import { AbstractFormatter } from "@fern-api/generator-commons";
 
 type Alias = string;
 type ImportPath = string;
@@ -59,7 +57,7 @@ export class Writer extends AbstractWriter {
         if (maybeAlias != null) {
             return maybeAlias;
         }
-        let alias = this.getValidAlias(path.basename(importPath));
+        let alias = this.getValidAlias(getBasename(importPath));
         while (alias in this.imports) {
             alias = "_" + alias;
         }

generators/go-v2/ast/src/context/AbstractGoGeneratorContext.ts

@@ -17,6 +17,7 @@ import { RelativeFilePath } from "@fern-api/fs-utils";
 import { go } from "..";
 import { TimeTypeReference, UuidTypeReference } from "../ast/Type";
 import { resolveRootImportPath } from "../custom-config/resolveRootImportPath";
+
 export interface FileLocation {
     importPath: string;
     directory: RelativeFilePath;

generators/go-v2/ast/src/custom-config/resolveRootImportPath.ts

@@ -1,5 +1,4 @@
-import { FernGeneratorExec } from "@fern-api/generator-commons";
-import path from "path";
+import { FernGeneratorExec, getBasename } from "@fern-api/generator-commons";
 import { BaseGoCustomConfigSchema } from "./BaseGoCustomConfigSchema";
 
 const DEFAULT_MODULE_PATH = "sdk";
@@ -65,7 +64,7 @@ function maybeAppendMajorVersionSuffix({
     importPath: string;
     majorVersion: string;
 }): string {
-    if (path.basename(importPath) === majorVersion) {
+    if (getBasename(importPath) === majorVersion) {
         return importPath;
     }
     return `${importPath}/${majorVersion}`;

generators/go-v2/dynamic-snippets/package.json

@@ -36,7 +36,6 @@
     "@fern-api/go-formatter": "workspace:*",
     "@fern-fern/ir-sdk": "^53.21.0",
     "@types/jest": "^29.5.12",
-    "@types/node": "^18.7.18",
     "depcheck": "^1.4.6",
     "eslint": "^8.56.0",
     "organize-imports-cli": "^0.10.0",

generators/go-v2/dynamic-snippets/src/__test__/utils/constant.ts

@@ -1,9 +1,5 @@
-import path from "path";
 import { AbsoluteFilePath } from "@fern-api/fs-utils";
 
 export const DYNAMIC_IR_TEST_DEFINITIONS_DIRECTORY = AbsoluteFilePath.of(
-    path.join(
-        __dirname,
-        "../../../../../../packages/cli/generation/ir-generator/src/dynamic-snippets/__test__/test-definitions"
-    )
+    `${__dirname}/../../../../../../packages/cli/generation/ir-generator/src/dynamic-snippets/__test__/test-definitions`
 );

generators/go-v2/dynamic-snippets/src/context/DynamicSnippetsGeneratorContext.ts

@@ -8,7 +8,6 @@ import { DiscriminatedUnionTypeInstance } from "../DiscriminatedUnionTypeInstanc
 import { DynamicTypeMapper } from "./DynamicTypeMapper";
 import { DynamicTypeInstantiationMapper } from "./DynamicTypeInstantiationMapper";
 import { go } from "@fern-api/go-ast";
-import path from "path";
 import { ErrorReporter, Severity } from "./ErrorReporter";
 import { FilePropertyMapper } from "./FilePropertyMapper";
 import { AbstractDynamicSnippetsGeneratorContext } from "@fern-api/generator-commons";
@@ -329,11 +328,11 @@ export class DynamicSnippetsGeneratorContext extends AbstractDynamicSnippetsGene
     }
 
     public getClientImportPath(): string {
-        return path.join(this.rootImportPath, "client");
+        return `${this.rootImportPath}/client`;
     }
 
     public getOptionImportPath(): string {
-        return path.join(this.rootImportPath, "option");
+        return `${this.rootImportPath}/option`;
     }
 
     public resolveEndpointOrThrow(rawEndpoint: string): DynamicSnippets.Endpoint[] {