Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace deprecated WillPopScope with PopScope #120

Merged
merged 6 commits into from
Apr 2, 2024
Merged

feat!: replace deprecated WillPopScope with PopScope #120

merged 6 commits into from
Apr 2, 2024

Conversation

furaiev
Copy link
Contributor

@furaiev furaiev commented Mar 28, 2024

Status

READY

Breaking Changes

YES

Description

This PR introduces replacing deprecated WillPopScope with PopScope.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Testing

@furaiev furaiev requested a review from felangel as a code owner March 28, 2024 12:47
@felangel felangel changed the title Replace deprecated WillPopScope with PopScope feat!: replace deprecated WillPopScope with PopScope Apr 2, 2024
@felangel felangel added the enhancement New feature or request label Apr 2, 2024
felangel
felangel approved these changes Apr 2, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
Thanks so much for the contribution! 💙

@felangel felangel merged commit bb8fbc2 into felangel:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmquintanadiaz vmquintanadiaz vmquintanadiaz approved these changes

@felangel felangel felangel approved these changes

Assignees

@furaiev furaiev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@furaiev @felangel @vmquintanadiaz @oleksii-furaiev-tide