-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let users pass max_threads as an argument to _avif.AvifDecoder #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fdintino gentle bump |
github-merge-queue bot
referenced
this pull request
in BSStudio/bss-web-file-api
Jul 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pillow-avif-plugin](https://togithub.com/fdintino/pillow-avif-plugin) | `1.4.3` -> `1.4.4` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/pillow-avif-plugin/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/pillow-avif-plugin/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/pillow-avif-plugin/1.4.3/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pillow-avif-plugin/1.4.3/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fdintino/pillow-avif-plugin (pillow-avif-plugin)</summary> ### [`v1.4.4`](https://togithub.com/fdintino/pillow-avif-plugin/releases/tag/v1.4.4) [Compare Source](https://togithub.com/fdintino/pillow-avif-plugin/compare/v1.4.3...v1.4.4) #### What's Changed - chore(ci): bump libavif to [`e10e6d9`](https://togithub.com/fdintino/pillow-avif-plugin/commit/e10e6d9)-2024-07-01; fix CI build issues by [@​fdintino](https://togithub.com/fdintino) in [https://github.com/fdintino/pillow-avif-plugin/pull/53](https://togithub.com/fdintino/pillow-avif-plugin/pull/53). See table below for new versions (all versions are upgrades from the 1.4.3 release). | | | |-------------|------------| | **libavif** | <b>1.0.3 ([e10e6d9](https://togithub.com/AOMediaCodec/libavif/commit/e10e6d98e6d1dbcdd409859a924d1b607a1e06dc))</b> | | **libaom** | **3.9.1** | | **dav1d** | **1.4.3** | | **SVT-AV1** | **2.1.1** | | **rav1e** | **0.7.1** | - feat: Allow users to pass `max_threads` to the avif encoder via `Image.save` by [@​yit-b](https://togithub.com/yit-b) in [https://github.com/fdintino/pillow-avif-plugin/pull/54](https://togithub.com/fdintino/pillow-avif-plugin/pull/54), originally in [https://github.com/fdintino/pillow-avif-plugin/pull/49](https://togithub.com/fdintino/pillow-avif-plugin/pull/49) - feat: Let users pass `max_threads` as an argument to `_avif.AvifDecoder` by [@​yit-b](https://togithub.com/yit-b) in [https://github.com/fdintino/pillow-avif-plugin/pull/50](https://togithub.com/fdintino/pillow-avif-plugin/pull/50) - chore(ci): build SVT-AV1 for aarch64 or arm64 by [@​RaphaelVRossi](https://togithub.com/RaphaelVRossi) in [https://github.com/fdintino/pillow-avif-plugin/pull/38](https://togithub.com/fdintino/pillow-avif-plugin/pull/38) - fix: keep alpha channel for images with mode P and custom transparency by [@​fdintino](https://togithub.com/fdintino) in [https://github.com/fdintino/pillow-avif-plugin/pull/56](https://togithub.com/fdintino/pillow-avif-plugin/pull/56); fixes [https://github.com/fdintino/pillow-avif-plugin/issues/48](https://togithub.com/fdintino/pillow-avif-plugin/issues/48) - fix: disable decoder strictness for `clap` and `pixi` properties by [@​fdintino](https://togithub.com/fdintino) in [https://github.com/fdintino/pillow-avif-plugin/pull/57](https://togithub.com/fdintino/pillow-avif-plugin/pull/57). fixes [https://github.com/fdintino/pillow-avif-plugin/issues/13](https://togithub.com/fdintino/pillow-avif-plugin/issues/13), fixes [https://github.com/fdintino/pillow-avif-plugin/issues/28](https://togithub.com/fdintino/pillow-avif-plugin/issues/28) - fix(ci): lint secrets permission error and macOS GHA runner homebrew `PATH` bug by [@​fdintino](https://togithub.com/fdintino) in [https://github.com/fdintino/pillow-avif-plugin/pull/55](https://togithub.com/fdintino/pillow-avif-plugin/pull/55) #### New Contributors - [@​RaphaelVRossi](https://togithub.com/RaphaelVRossi) made their first contribution in [https://github.com/fdintino/pillow-avif-plugin/pull/38](https://togithub.com/fdintino/pillow-avif-plugin/pull/38) **Full Changelog**: fdintino/pillow-avif-plugin@v1.4.3...v1.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/BSStudio/bss-web-file-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the Image.open API doesn't yet let you pass arguments nicely to the underlying decoder, it would be really nice to be able to configure the decoder's max_threads option via this plugin when I know that the image I am reading is an AVIF. Example:
decode_threads.py
The default behavior is unchanged, max_threads is still 0 when you open an avif via Image.open(). Only when you drop down a layer can you configure this.
As with #49, maybe we should consider a more reasonable default value for the decoder's max_threads for the same reasons.
Reproduce: