Add option to find_upstream to keep nodes visited even if not found #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to seek upstream until you either find a particular node or terminate at an input or initializer. This is almost handled by
find_upstream
, except for it returning the empty list in case the search terminates. This is reasonable default behavior. By adding a flag, handling the second use case is almost free. The option is disabled by default to not change the existing behavior.By the way: Is there a particular reason to return the empty list if there is no producer and to return None if there is a producer without inputs? It is probably of interest to distinguish these tow cases, but was this a deliberate choice utilized somewhere? This behavior is not changed by this PR.