Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multiple rod IO #181

Closed
wants to merge 7 commits into from
Closed

[WIP] Multiple rod IO #181

wants to merge 7 commits into from

Conversation

fankiat
Copy link
Owner

@fankiat fankiat commented Jan 27, 2023

Fixes #180

An illustration of the resulting IO output as below. The rods are all in the same file for each timestamp, so users only need to load a file on paraview and all the rods added to the io would be rendered as separate rods.

test_multiple_rod.mp4

@fankiat fankiat added enhancement New feature or request prio:high High priority labels Jan 27, 2023
@fankiat fankiat requested a review from bhosale2 January 27, 2023 22:28
@fankiat fankiat self-assigned this Jan 27, 2023
@fankiat fankiat marked this pull request as draft January 27, 2023 22:32
@fankiat fankiat changed the title Multiple rod IO [WIP] Multiple rod IO Jan 27, 2023
@fankiat fankiat changed the title [WIP] Multiple rod IO Multiple rod IO Jan 28, 2023
@fankiat fankiat marked this pull request as ready for review January 28, 2023 00:46
@fankiat fankiat marked this pull request as draft January 31, 2023 04:29
@fankiat
Copy link
Owner Author

fankiat commented Jan 31, 2023

I noticed that while this implementation is convenient, it does not scale well. For <100 rods, it's seems to run fine, but for ~1000 rods, it slows down significantly. As such, I am putting this as WIP for the time being.

@fankiat fankiat changed the title Multiple rod IO [WIP] Multiple rod IO Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple rod io
1 participant