Status variable type #31468
Open
Status variable type #31468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abay-2002
reviewed
Nov 10, 2024
There was a problem hiding this comment.
yeah that would
- Provide stronger type checking, reducing the risk of bugs.
- Improve code readability by clearly indicating that status is expected to be a string.
- Align with TypeScript best practices by avoiding the use of any when a more specific type can be used.
Let me know yo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #31467
I noticed the status variable in the ReactPromise function of the ReactFlightClient file, is of type any. After carefully checking every other mention of this variable to make sure about it's type, I changed it into string to better suite the intented type and avoid risk of bugs.
How did you test this change?
I run the following commands: