Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor _get_trial_indices_to_fetch #3086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor _get_trial_indices_to_fetch #3086

wants to merge 1 commit into from

Commits on Nov 25, 2024

  1. Refactor _get_trial_indices_to_fetch (facebook#3086) 

    Summary:

This diff refactors the _get_trial_indices_to_fetch method to improve its readability and maintainability. The changes include:

1. Extracting a new method _identify_trial_indices_to_fetch that takes both old and new trial statuses as input
2. Simplifying the logic for identifying newly completed, running, and previously completed trials with new data after completion.
3. Improving code organization and reducing duplication

Differential Revision: D66045355
    @paschai @facebook-github-bot
    paschai authored and facebook-github-bot committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9a98ad8 View commit details
    Browse the repository at this point in the history