-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- configure itty-router - simplify `./routes` due to controlled number of flows
- routes & controllers MVP structure completed & clean - function calls working within some routes - some work has begun on separation of concerns between controllers, routes & models - controllers now have descriptive names - routers call sequentially & successfully - routers point towards controllers in anticipation of calling them BREAKING CHANGE:
- Routers mounted correctly - Test messages within each router
Opening localhost in the browser returns a linklist
**Instructions** - `npm install` - `npm run dev` will: - run the project directly without compiling - restart if you make any changes to the code, allowing you to see changes in realtime **Packages** - New Installs - `@types/prompt-sync` - Updates - `@types/node`: `22.5.5 --> 22.7.4` - `tsx`: `dependencies --> devDependencies` **Configuration Changes** - `tsconfig.json` - target: `es2016 --> es2020` - module: `NodeNext --> ESNext` - strict: `false --> true` - `nodemon.json` - exec: `"ts-node --esm -r tsconfig-paths/register ./src/app.ts" --> "tsx src/app.ts"` BREAKING CHANGE:
maxitect
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Great Router Update
1. Scripts
npm run dev
2. Packages
New Packages
@types/prompt-sync
Updated Packages
@types/node
22.5.5
22.7.4
tsx
dependencies
devDependencies
3. Configuration
tsconfig
target
es2016
es2020
tsconfig
module
NodeNext
ESNext
tsconfig
strict
false
true
nodemon
exec
"ts-node --esm -r tsconfig-paths/register ./src/app.ts"
"tsx src/app.ts"
4. Usage & Endpoints
/
/api/
/api/transfer
/api/user
/api/openAI
/api/spotify
5. Documents & Notes
./docs/DATAFLOW.md
6. Project Structure
./src/controllers/${apiName}/index.ts
refactored as modular function calls./src/controllers/server
renamed to./src/controllers/user
./models
created as a placeholder for later architecture7. Issues
Related to #23, #25, #26, #41, #51, #52, #53
Closes #6, #7, #9, #10, #12, #13, #14, #15, #17, #18, #19, #21, #33, #34, #35, #37, #38, #40, #44, #45, #46, #47, #48, #49, #50, #55, #70