Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip! feat(symphony-ws): Add Dockerfile #1

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zapling
Copy link
Member

@zapling zapling commented Mar 1, 2024

Attempt to add a Dockerfile for the backend. This one compiles and starts the wildfly instance with the compiled war file. Currently it fails to connect to a database (because there is none)

ENV WILDFLY_HOME /opt/jboss/wildfly
ENV DEPLOY_DIR ${WILDFLY_HOME}/standalone/deployments/

ENV DATASOURCE_NAME ApplicationDS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if symphony-ws requires a specific name here.

fi

echo "=> Start Wildfly"
$WILDFLY_HOME/bin/standalone.sh -b=0.0.0.0 -c standalone.xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme mentions the standalone-full.xml but unsure what the difference is

@ann-hav
Copy link

ann-hav commented Mar 20, 2024

Just discovered this fork! Kudos 👏 Did you mean to bring this to our attention on the upstream? Or is this PR for internal review at @fabled-se ?
I'd love to take a look at this, maybe next week.

/ Ann på HaV

@zapling
Copy link
Member Author

zapling commented Mar 21, 2024

We where looking into running this app inside Kubernetes, we are working a bit with Ocean Data and they wanted to know how hard it would be to host it.

Is there an official interest in providing a dockerfile for the project, our interest is otherwise pretty low in trying to upstream, since the use-case of packaging and running this inside kubernetes seems pretty niche?

@ann-hav
Copy link

ann-hav commented Mar 25, 2024

No, this honestly isn't prioritised at our end.
Like it says in our issue description (havochvatten#49), primarily a workable docker image may be desirable for us in that it would allow us to run the suite of API tests in the Github CI pipeline. This would be "nice to have" but it's not exactly crucial.
That said, all contributions are encouraged, and of course we'd be happy to incorporate a working solution!

Regarding your pursuit of a setup with Kubernetes, my guess is that heap memory could become an issue for you since Symphony can be quite RAM intensive when working with large rasters. But I don't have a lot of experience with Kubernetes.

I feel I should confess however, being the maintainer of this project, it occurs to me that regrettably part of the enclosed documentation is out of date. In particular database/DataImportREADME.md doesn't accurately describe the current procedure for providing metadata at this point. Just wanted to mention this, to perhaps anticipate any problems in achieving a working setup if you'll be moving forward with this. I'll look into getting this fixed appropriately, in the meantime I'll go ahead and remove any misleading information on the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants