raise error to be captured on parser failure

fablabbcn · Oct 14, 2024 · 232da49 · 232da49
1 parent 4ecda28
commit 232da49
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/lib/raw_mqtt_message_parser.rb b/app/lib/raw_mqtt_message_parser.rb
@@ -6,7 +6,9 @@ def initialize
   end
 
   def parse(message)
-    parser.parse(self.convert_to_ascii(message.strip))&.to_hash
+    message = parser.parse(self.convert_to_ascii(message.strip))&.to_hash
+    raise "Message not parsed: #{message}" unless message
+    return message
   end
 
   private

diff --git a/spec/lib/raw_mqtt_message_parser_spec.rb b/spec/lib/raw_mqtt_message_parser_spec.rb
@@ -59,10 +59,9 @@
     expect(parsed).to eq({ data: [ { recorded_at: "2024-09-25T13:19:38Z", sensors: [{id: "100", value: "-2000.12345"}] }]})
   end
 
-  it "returns nil if no valid message parsed" do
+  it "raises an error if no valid message parsed" do
     message = "ceci n'est pas un message"
-    parsed = parser.parse(message)
-    expect(parsed).to eq(nil)
+    expect {parser.parse(message)}.to raise_error(RuntimeError)
   end
 
   it "parses timestamps at any position in the packet" do