Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move toolchain wrappers to repo f4pga #2509

Merged
merged 4 commits into from
May 17, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 18, 2022

No description provided.

@probot-autolabeler probot-autolabeler bot added the type-utils Issues is related to the scripts inside the repo. label Mar 18, 2022
@probot-autolabeler probot-autolabeler bot added the type-infra Issues related to infra like travis. label Mar 19, 2022
@umarcor umarcor force-pushed the umarcor/move-wrappers branch 6 times, most recently from 6c4b49a to 8f54208 Compare March 22, 2022 13:48
@umarcor umarcor force-pushed the umarcor/move-wrappers branch 3 times, most recently from dddec93 to c7384ac Compare April 7, 2022 09:44
@umarcor umarcor force-pushed the umarcor/move-wrappers branch 3 times, most recently from 81fb8b4 to a056968 Compare April 13, 2022 01:15
@umarcor umarcor force-pushed the umarcor/move-wrappers branch 10 times, most recently from 6906291 to 5525adc Compare April 23, 2022 12:14
@umarcor umarcor marked this pull request as ready for review April 23, 2022 23:50
@umarcor umarcor force-pushed the umarcor/move-wrappers branch 3 times, most recently from e37a0b3 to e895b07 Compare April 25, 2022 12:29
Copy link
Contributor

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current version emits complete toolchain (including wrappers) when a user calls make install. The new version will not do that at all - it will only emit architecture definitions. We should clearly say about this change somewhere (as it will be confusing for "old" users)

@umarcor
Copy link
Contributor Author

umarcor commented Apr 26, 2022

FTR, there is https://github.com/antmicro/f4pga-arch-defs/commits/umarcor/pip-req (note antmicro@c612abd) but unfortunately I couldn't get it to work...

GitHub
FOSS architecture definitions of FPGA hardware useful for doing PnR device generation. - Commits · antmicro/f4pga-arch-defs

@kgugala
Copy link
Contributor

kgugala commented Apr 27, 2022

FTR, there is https://github.com/antmicro/f4pga-arch-defs/commits/umarcor/pip-req (note antmicro@c612abd) but unfortunately I couldn't get it to work...

GitHub**Commits · antmicro/f4pga-arch-defs**FOSS architecture definitions of FPGA hardware useful for doing PnR device generation. - Commits · antmicro/f4pga-arch-defs

sure, but this is CI only. I'm talking about users who would want to manually install stuff on their machines

GitHub
FOSS architecture definitions of FPGA hardware useful for doing PnR device generation. - Commits · antmicro/f4pga-arch-defs

@umarcor umarcor force-pushed the umarcor/move-wrappers branch 4 times, most recently from c62cb0f to 71d28ce Compare May 13, 2022 15:42
@umarcor
Copy link
Contributor Author

umarcor commented May 14, 2022

This PR was updated to install the f4pga package through the conda-lock.yml file. Therefore, users should see no difference compared to the previous behaviour.

@umarcor umarcor requested review from kgugala and tmichalak May 14, 2022 01:25
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
@probot-autolabeler probot-autolabeler bot added lang-python Issue uses (or requires) Python language. type-docs Issue is related to documentation. labels May 16, 2022
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
@tmichalak
Copy link
Contributor

LGTM. Merging.

@Xiretza
Copy link
Contributor

Xiretza commented May 19, 2022

So what happened to these wrappers? Are they now stored in another repo, or are they gone completely? What's the upgrade path for users?

@tmichalak
Copy link
Contributor

tmichalak commented May 19, 2022

@Xiretza the toolchain wrappers have been moved to the f4pga repository, but this is just a transition stage before switching to their newer Python version that are also in the f4pga repo. You can read about the CLI in the documentation. The current changes should be transparent to arch-defs users, but we will be heading towards adopting the new CLI in f4pga-examples so it effectlively becomes the default interface.

@Xiretza
Copy link
Contributor

Xiretza commented May 19, 2022

Ah, I see, thanks for the information - I'll get acquainted with the new tooling then!

@umarcor
Copy link
Contributor Author

umarcor commented May 19, 2022

@Xiretza, see #2669.

So, we are in a transition period. Well, actually, we've spent the last 2-3 month transitioning (from Kokoro to GitHub runners, from SymbiFlow to F4PGA and now from makefiles to Python).

If you want to bump the arch-defs packages in your environment, and keep using the same makefiles/scripts you have, I suggest to read #2669. You just need to define F4PGA_ENV_BIN and F4PGA_ENV_SHARE pointing to the Conda bin and the location where you extracted the packages, respectively. That will "temporarily stabilize" your setup, until you get familiar with the new tooling system (and we improve the docs about how to use f4pga build in this repo, in examples, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-python Issue uses (or requires) Python language. type-docs Issue is related to documentation. type-infra Issues related to infra like travis. type-utils Issues is related to the scripts inside the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants