Add tests for malformed init code #92

lrettig · 2018-10-07T22:54:11Z

Checks 1. that CREATE returns 1 (failure), 2. that result (created
contract address) is empty

src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeHasStartFromTxFiller.yml

hugo-dc · 2018-10-08T02:47:22Z

src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeNoMainFromTxFiller.yml

+          balance: '99916113919'
+        # newly-created contract
+        # expect code to be empty since create should fail
+        # 6295ee1b4f6dd65047762f924ecd367c17eabf8f:


you could uncomment this and add "shouldnotexist": "1"

Thanks. Do you know if there's a way to make sure that no new contracts get created?

lrettig · 2018-10-08T05:33:44Z

@axic take a look at

tests/src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeInvalidMainFiller.yml

Line 27 in c01e1bb

# (export "main" (func $main (param i32)))

, is this what you had in mind for this test? Note that it produces the following when I run it for some reason: Error in parsing WASM binary: 'Section extends beyond end of input'

lrettig · 2018-10-09T02:14:52Z

This is done, it contains all of the missing tests that @axic marked "testnet critical" here. Note that a couple of these tests don't pass against the hera branch I've been using for testing (https://github.com/ewasm/hera/tree/verifycontract):

initMalformedBytecodeInvalidMain
initMalformedBytecodeInvalidMainFromTx

These tests are failing (with binaryen) due to ewasm/hera#442 (and with wabt due to ewasm/hera#441).

src/GeneralStateTestsFiller/stEWASMTests/storedMalformedBytecodeHasStartFromTxFiller.yml

src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeInvalidMainFiller.yml

src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeInvalidMainFromTxFiller.yml

src/GeneralStateTestsFiller/stEWASMTests/storedMalformedBytecodeHasStartFiller.yml

hugo-dc

It looks good to me, still pending to take a decision about the current tests which are failing due to pending issues in binaryen/wabt

lrettig · 2018-10-19T02:37:31Z

Thanks @hugo-dc!. Agree, @axic any thoughts? This is waiting on ewasm/hera#441 and ewasm/hera#442.

axic · 2018-10-23T17:14:05Z

@lrettig @hugo-dc is it in any way possible to split this PR and merge those which pass with Hera already?

lrettig · 2018-10-25T12:18:12Z

@axic I split out the failing tests into #96

CREATE should fail if the init code contains a 'start' section. Checks 1. that CREATE returns 1 (failure), 2. that result (created contract address) is empty

Tests that a contract is not created from a tx when the bytecode contains a (start) section.

Try to create a contract from a transaction where the init code is missing a main section

CREATE with init code that contains no main

Tests init code with missing memory export on create

Same as last test, but from tx rather than from create

Test for malformed bytecode (has start section) in code returned from init code, rather than in init code itself

Same as previous test, but tests bytecode returned from tx

lrettig · 2018-10-25T21:02:29Z

Rebased onto Hugo's latest changes. It looks like Hugo renamed a test to storedMalformedBytecodeHasStartFromTx which conflicted with a new one I wrote. They are basically identical, the only difference is that the contract I stored was minimal, with less bytecode. I accepted Hugo's version and just copied over a few helpful comments from mine.

@hugo-dc @axic this is ready for one final review and then merging.

lrettig force-pushed the malformed-init-code branch from ed10c23 to 142fe9d Compare October 7, 2018 22:55

lrettig changed the title ~~Add test for missing main in init code~~ Add test for start section in init code Oct 7, 2018

axic approved these changes Oct 7, 2018

View reviewed changes

jakelang approved these changes Oct 7, 2018

View reviewed changes

lrettig changed the title ~~Add test for start section in init code~~ Add test for start section in init code (WIP) Oct 8, 2018

lrettig commented Oct 8, 2018

View reviewed changes

src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeHasStartFromTxFiller.yml Outdated Show resolved Hide resolved

lrettig changed the title ~~Add test for start section in init code (WIP)~~ Add test for malformed init code (WIP) Oct 8, 2018

hugo-dc reviewed Oct 8, 2018

View reviewed changes

lrettig changed the title ~~Add test for malformed init code (WIP)~~ Add tests for malformed init code Oct 9, 2018

hugo-dc reviewed Oct 9, 2018

View reviewed changes

hugo-dc approved these changes Oct 18, 2018

View reviewed changes

lrettig mentioned this pull request Oct 25, 2018

Add tests for malformed init code (2) #96

Merged

lrettig force-pushed the malformed-init-code branch from fb15649 to c5cc4a1 Compare October 25, 2018 12:17

lrettig added 12 commits October 25, 2018 22:47

Add test for 'start' section in init code

aad9bd1

CREATE should fail if the init code contains a 'start' section. Checks 1. that CREATE returns 1 (failure), 2. that result (created contract address) is empty

Fix filenames

1305525

Add initMalformedBytecodeHasStartFromTx test

70317c1

Tests that a contract is not created from a tx when the bytecode contains a (start) section.

Add initMalformedBytecodeNoMainFromTx test

869f20f

Try to create a contract from a transaction where the init code is missing a main section

Add shouldnotexist to initMalformedBytecodeNoMainFromTx

f9296ab

Add initMalformedBytecodeNoMain test

42b5428

CREATE with init code that contains no main

Comment out compiled contract source

6c9c679

Add shouldnotexist to initMalformedBytecodeHasStartFromTx

ee83d42

Add initMalformedBytecodeMissingMemoryExport test

dabe25b

Tests init code with missing memory export on create

Add initMalformedBytecodeMissingMemoryExportFromTx test

a43ca3a

Same as last test, but from tx rather than from create

Adds storedMalformedBytecodeHasStart test

7879178

Test for malformed bytecode (has start section) in code returned from init code, rather than in init code itself

Adds storedMalformedBytecodeHasStartFromTx test

b96ed5a

Same as previous test, but tests bytecode returned from tx

lrettig force-pushed the malformed-init-code branch from c5cc4a1 to b96ed5a Compare October 25, 2018 20:59

Refill storedMalformedBytecodeHasStartFromTx

a6b4d98

axic approved these changes Oct 25, 2018

View reviewed changes

axic merged commit a859f75 into ewasm:wasm-tests Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for malformed init code #92

Add tests for malformed init code #92

lrettig commented Oct 7, 2018

hugo-dc Oct 8, 2018

lrettig Oct 8, 2018

lrettig commented Oct 8, 2018

lrettig commented Oct 9, 2018

hugo-dc left a comment

lrettig commented Oct 19, 2018 •

edited

Loading

axic commented Oct 23, 2018

lrettig commented Oct 25, 2018

lrettig commented Oct 25, 2018

Add tests for malformed init code #92

Add tests for malformed init code #92

Conversation

lrettig commented Oct 7, 2018

hugo-dc Oct 8, 2018

Choose a reason for hiding this comment

lrettig Oct 8, 2018

Choose a reason for hiding this comment

lrettig commented Oct 8, 2018

lrettig commented Oct 9, 2018

hugo-dc left a comment

Choose a reason for hiding this comment

lrettig commented Oct 19, 2018 • edited Loading

axic commented Oct 23, 2018

lrettig commented Oct 25, 2018

lrettig commented Oct 25, 2018

lrettig commented Oct 19, 2018 •

edited

Loading