-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Turn into trait #29
Open
axic
wants to merge
1
commit into
master
Choose a base branch
from
turn-into-trait
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be rebased. |
jakelang
reviewed
Dec 6, 2018
jakelang
reviewed
Dec 6, 2018
jakelang
reviewed
Dec 6, 2018
This is an old branch I turned into a PR so that it is not just lost. We can close the PR if it makes sen. |
@axic do you want to build on this? or just rewrite the PR |
It can be cleaned up if we agree on an approach. |
axic
force-pushed
the
turn-into-trait
branch
4 times, most recently
from
February 14, 2019 13:35
4142537
to
c8afdcd
Compare
axic
force-pushed
the
turn-into-trait
branch
2 times, most recently
from
May 28, 2019 14:54
d21dcb6
to
84fe70b
Compare
jakelang
reviewed
May 28, 2019
Updates properly with current types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.