Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with JGAAP Repo #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IComplainInComments
Copy link

Here is the request to merge the new JGAAP into the main repository,

Copy link
Member

@DavidBerdik DavidBerdik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the .gradle directory to .gitignore and remove the folder's contents?

@IComplainInComments
Copy link
Author

Alright those changes should of been made.

@DavidBerdik
Copy link
Member

Alright those changes should of been made.

Thank you!

@DavidBerdik
Copy link
Member

Trying to use Gradle to build using the command line, I get the following error when building on Windows:

C:\Users\berdikd\Documents\JGAAP>gradlew.bat build
Downloading https://services.gradle.org/distributions/gradle-8.8-bin.zip
.............10%.............20%.............30%.............40%.............50%.............60%..............70%.............80%.............90%.............100%

Welcome to Gradle 8.8!

Here are the highlights of this release:
 - Running Gradle on Java 22
 - Configurable Gradle daemon JVM
 - Improved IDE performance for large projects

For more details see https://docs.gradle.org/8.8/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
> Task :jgaap:processTestResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':jgaap:processTestResources' (type 'ProcessResources').
  - Gradle detected a problem with the following location: 'C:\Users\berdikd\Documents\JGAAP\jgaap\build\classes\java\main\com\jgaap\resources'.

    Reason: Task ':jgaap:compileTestJava' uses this output of task ':jgaap:processTestResources' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':jgaap:processTestResources' as an input of ':jgaap:compileTestJava'.
      2. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:compileTestJava' using Task#dependsOn.
      3. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:compileTestJava' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.8/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.
  - Gradle detected a problem with the following location: 'C:\Users\berdikd\Documents\JGAAP\jgaap\build\classes\java\main\com\jgaap\resources'.

    Reason: Task ':jgaap:jar' uses this output of task ':jgaap:processTestResources' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':jgaap:processTestResources' as an input of ':jgaap:jar'.
      2. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:jar' using Task#dependsOn.
      3. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:jar' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.8/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 1m 32s
8 actionable tasks: 8 executed

@IComplainInComments
Copy link
Author

Trying to use Gradle to build using the command line, I get the following error when building on Windows:

C:\Users\berdikd\Documents\JGAAP>gradlew.bat build
Downloading https://services.gradle.org/distributions/gradle-8.8-bin.zip
.............10%.............20%.............30%.............40%.............50%.............60%..............70%.............80%.............90%.............100%

Welcome to Gradle 8.8!

Here are the highlights of this release:
 - Running Gradle on Java 22
 - Configurable Gradle daemon JVM
 - Improved IDE performance for large projects

For more details see https://docs.gradle.org/8.8/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
> Task :jgaap:processTestResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':jgaap:processTestResources' (type 'ProcessResources').
  - Gradle detected a problem with the following location: 'C:\Users\berdikd\Documents\JGAAP\jgaap\build\classes\java\main\com\jgaap\resources'.

    Reason: Task ':jgaap:compileTestJava' uses this output of task ':jgaap:processTestResources' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':jgaap:processTestResources' as an input of ':jgaap:compileTestJava'.
      2. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:compileTestJava' using Task#dependsOn.
      3. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:compileTestJava' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.8/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.
  - Gradle detected a problem with the following location: 'C:\Users\berdikd\Documents\JGAAP\jgaap\build\classes\java\main\com\jgaap\resources'.

    Reason: Task ':jgaap:jar' uses this output of task ':jgaap:processTestResources' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':jgaap:processTestResources' as an input of ':jgaap:jar'.
      2. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:jar' using Task#dependsOn.
      3. Declare an explicit dependency on ':jgaap:processTestResources' from ':jgaap:jar' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.8/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 1m 32s
8 actionable tasks: 8 executed

UUUGGGHHH This is because I put int he test code from the old JGAAP test base into my base, and I guess Gradle is adding Test proceedures. Ill look into disabling or porting the tests over.

@DavidBerdik
Copy link
Member

UUUGGGHHH This is because I put int he test code from the old JGAAP test base into my base, and I guess Gradle is adding Test proceedures. Ill look into disabling or porting the tests over.

Thanks! Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants